Issue 23701015: Merge 220596 "Differentiate between 'connect-failed' and 'bad-pa..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23701015: Merge 220596 "Differentiate between 'connect-failed' and 'bad-pa..." (Closed)

Created:
7 years, 3 months ago by stevenjb

Modified:
7 years, 3 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1599/src/

Visibility:
Public.

More Reviews

Description

Merge 220596 "Differentiate between 'connect-failed' and 'bad-pa..." > Differentiate between 'connect-failed' and 'bad-passphrase' > > Now that all connection requests are going through > NetworkConnectionHandler we can start to improve the connect flow > logic. > > 'connect-failed' can indicate a lot of things; we shouldn't assume that > configuration is required when that Error state is set. > > BUG=278559 > R=pneubeck@chromium.org > > Review URL: https://codereview.chromium.org/22867045 TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221734

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -40 lines)			Patch
MM	ash/system/chromeos/network/network_connect.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/system/chromeos/network/network_connect.cc	View	4 chunks	+7 lines, -5 lines	0 comments	Download
M	ash/system/chromeos/network/network_state_notifier.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chromeos/network/network_connection_handler.h	View	2 chunks	+28 lines, -15 lines	0 comments	Download
M	chromeos/network/network_connection_handler.cc	View	5 chunks	+4 lines, -16 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

stevenjb

7 years, 3 months ago (2013-09-06 17:48:20 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r221734 (presubmit successful).

Expand Messages | Collapse Messages