Gradients are serialized (and can be constructed) as SkColor4f + SkColorSpace

Gradients are serialized (and can be constructed) as SkColor4f + SkColorSpace

Added gradient shader factories that take SkColor4f + SkColorSpace.
Modified Descriptor to only store SkColor4f + SkColorSpace.
Existing factories make use of helper code to convert SkColor and
forward to the new factories.

Bumped SKP version to handle new gradient serialization format.
I was toying with using half-float when serializing SkColor4f,
despite my aggressive packing of flags, this format is significantly
bigger.

Also added GM to use 4f factories. This GM should (and does)
look identical to the existing gradients GM.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002

Committed: https://skia.googlesource.com/skia/+/e25d71ccbcdb47c7ee7bdf13235066092ae11af3

[Brian Osman, 2016-09-26 20:44:40]

Description was changed from

==========
Gradient shader factories that take SkColor4f + SkColorSpace

Also added GM to use 4f factories. Should be identical to old style.

BUG=skia:
==========

to

==========
Gradient shader factories that take SkColor4f + SkColorSpace

Also added GM to use 4f factories. Should be identical to old style.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002
==========

[Brian Osman, 2016-09-26 20:47:31]

brianosman@google.com changed reviewers:
+ fmalita@chromium.org, reed@google.com

[Brian Osman, 2016-09-26 20:47:32]

This is a lot of typing. We could reduce that substantially if we made the old
factories do the SkColor -> SkColor4f conversion, and supply sRGB as the color
space. But we don't have serialization of the 4f data yet, and I need the 4f
factories to implement that. :/

[Brian Osman, 2016-09-26 20:54:02]

Description was changed from

==========
Gradient shader factories that take SkColor4f + SkColorSpace

Also added GM to use 4f factories. Should be identical to old style.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002
==========

to

==========
Gradient shader factories that take SkColor4f + SkColorSpace

Also added GM to use 4f factories. Should be identical to old style.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002
==========

[Brian Osman, 2016-09-28 15:16:02]

Description was changed from

==========
Gradient shader factories that take SkColor4f + SkColorSpace

Also added GM to use 4f factories. Should be identical to old style.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002
==========

to

==========
Gradient shader factories that take SkColor4f + SkColorSpace

Also added GM to use 4f factories. This GM should (and does)
look identical to the existing gradients GM.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002
==========

[Brian Osman, 2016-09-28 15:20:28]

Description was changed from

==========
Gradient shader factories that take SkColor4f + SkColorSpace

Also added GM to use 4f factories. This GM should (and does)
look identical to the existing gradients GM.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002
==========

to

==========
Gradients are serialized (and can be constructed) as SkColor4f + SkColorSpace

Added gradient shader factories that take SkColor4f + SkColorSpace.
Modified Descriptor to only store SkColor4f + SkColorSpace.
Existing factories make use of helper code to convert SkColor and
forward to the new factories.

Bumped SKP version to handle new gradient serialization format.
I was toying with using half-float when serializing SkColor4f,
despite my aggressive packing of flags, this format is significantly
bigger.

Also added GM to use 4f factories. This GM should (and does)
look identical to the existing gradients GM.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002
==========

[reed1, 2016-09-28 15:25:21]

api lgtm

details in lineargradient I defer to florin

[f(malita), 2016-09-28 15:41:53]

lgtm

https://codereview.chromium.org/2370063002/diff/100001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/2370063002/diff/100001/include/core/SkPicture...
include/core/SkPicture.h:242: 
nit: static_assert(MIN_PICTURE_VERSION <= 48, "Remove legacy gradient
deserialization code.")?

https://codereview.chromium.org/2370063002/diff/100001/src/effects/gradients/...
File src/effects/gradients/SkGradientShader.cpp (right):

https://codereview.chromium.org/2370063002/diff/100001/src/effects/gradients/...
src/effects/gradients/SkGradientShader.cpp:16: enum GradientSerializationFlags {
nit: enum class + drop _GSF suffix?

[Brian Osman, 2016-09-28 15:46:17]

https://codereview.chromium.org/2370063002/diff/100001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/2370063002/diff/100001/include/core/SkPicture...
include/core/SkPicture.h:242: 
On 2016/09/28 15:41:52, f(malita) wrote:
> nit: static_assert(MIN_PICTURE_VERSION <= 48, "Remove legacy gradient
> deserialization code.")?

Acknowledged. I'll add a comment to the version log above, too.

https://codereview.chromium.org/2370063002/diff/100001/src/effects/gradients/...
File src/effects/gradients/SkGradientShader.cpp (right):

https://codereview.chromium.org/2370063002/diff/100001/src/effects/gradients/...
src/effects/gradients/SkGradientShader.cpp:16: enum GradientSerializationFlags {
On 2016/09/28 15:41:52, f(malita) wrote:
> nit: enum class + drop _GSF suffix?

Seems like that would make all of my usage harder (since I'm doing arithmetic
and bitwise ops with the integral values)?

[Brian Osman, 2016-09-28 15:50:14]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-09-28 15:50:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmalita@chromium.org, reed@google.com
Link to the patchset: https://codereview.chromium.org/2370063002/#ps120001
(title: "Add comment and static_assert")

[commit-bot: I haz the power, 2016-09-28 15:50:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 15:53:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 15:53:29]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[f(malita), 2016-09-28 15:54:46]

https://codereview.chromium.org/2370063002/diff/100001/src/effects/gradients/...
File src/effects/gradients/SkGradientShader.cpp (right):

https://codereview.chromium.org/2370063002/diff/100001/src/effects/gradients/...
src/effects/gradients/SkGradientShader.cpp:16: enum GradientSerializationFlags {
On 2016/09/28 15:46:17, Brian Osman wrote:
> On 2016/09/28 15:41:52, f(malita) wrote:
> > nit: enum class + drop _GSF suffix?
> 
> Seems like that would make all of my usage harder (since I'm doing arithmetic
> and bitwise ops with the integral values)?

Ack, good point.

[Brian Osman, 2016-09-28 17:30:24]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-09-28 17:30:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmalita@chromium.org, reed@google.com
Link to the patchset: https://codereview.chromium.org/2370063002/#ps140001
(title: "Better assert?")

[commit-bot: I haz the power, 2016-09-28 17:30:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 17:36:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 17:36:58]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[Brian Osman, 2016-09-28 17:52:22]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-09-28 17:52:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmalita@chromium.org, reed@google.com
Link to the patchset: https://codereview.chromium.org/2370063002/#ps160001
(title: "Widen storage for flags. Shift used bits to be contiguous. Document
layout.")

[commit-bot: I haz the power, 2016-09-28 17:52:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 18:27:30]

Description was changed from

==========
Gradients are serialized (and can be constructed) as SkColor4f + SkColorSpace

Added gradient shader factories that take SkColor4f + SkColorSpace.
Modified Descriptor to only store SkColor4f + SkColorSpace.
Existing factories make use of helper code to convert SkColor and
forward to the new factories.

Bumped SKP version to handle new gradient serialization format.
I was toying with using half-float when serializing SkColor4f,
despite my aggressive packing of flags, this format is significantly
bigger.

Also added GM to use 4f factories. This GM should (and does)
look identical to the existing gradients GM.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002
==========

to

==========
Gradients are serialized (and can be constructed) as SkColor4f + SkColorSpace

Added gradient shader factories that take SkColor4f + SkColorSpace.
Modified Descriptor to only store SkColor4f + SkColorSpace.
Existing factories make use of helper code to convert SkColor and
forward to the new factories.

Bumped SKP version to handle new gradient serialization format.
I was toying with using half-float when serializing SkColor4f,
despite my aggressive packing of flags, this format is significantly
bigger.

Also added GM to use 4f factories. This GM should (and does)
look identical to the existing gradients GM.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2370063002

Committed:
https://skia.googlesource.com/skia/+/e25d71ccbcdb47c7ee7bdf13235066092ae11af3
==========

[commit-bot: I haz the power, 2016-09-28 18:27:31]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/e25d71ccbcdb47c7ee7bdf13235066092ae11af3