Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2370023002: Revert of Reland: Ntp: restore scroll position. (Closed)

Created:
4 years, 2 months ago by Khushal
Modified:
4 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, ntp-dev+reviews_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Ntp: restore scroll position. (patchset #2 id:20001 of https://codereview.chromium.org/2365313002/ ) Reason for revert: Breaks AndroidTests(Dbg: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/36381 Original issue's description: > Reland: Ntp: restore scroll position. > > * The scroll position is stored as extra data on the NavigationEntry. > * The main use case handled is when the user clicks on a suggested > article and then back to view more suggestions. Maintaining scroll position helps maintain context and flow here. > * It is the RecyclerView Adapter position that is stored and restored, so if the device is rotated in the meantime, scroll restore will still present the same content as long as the underlying data has not changed. > * Because the underlying data is subject to change a few times per day, the scroll position is not persisted. It would be confusing the restore to an old position that now shows different content. > > BUG=606356 > TBR=clamy,bauerb,tedchoc > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/22b18a9a6d4f421ddb6d4f74280a571bf7dca4f6 > Cr-Commit-Position: refs/heads/master@{#420075} > > patch from issue 2327083002 at patchset 160001 (http://crrev.com/2327083002#ps160001) > > Committed: https://crrev.com/2c78ced6c8ce46eec8c9f7100b14b3414b7cbc07 > Cr-Commit-Position: refs/heads/master@{#420896} TBR=tedchoc@chromium.org,clamy@chromium.org,bauerb@chromium.org,mvanouwerkerk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=606356 Committed: https://crrev.com/14b97a44b845781fed2b493e948fd7d6509586df Cr-Commit-Position: refs/heads/master@{#420963}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
Khushal
Created Revert of Reland: Ntp: restore scroll position.
4 years, 2 months ago (2016-09-26 19:33:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370023002/1
4 years, 2 months ago (2016-09-26 19:34:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 19:35:31 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 19:39:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14b97a44b845781fed2b493e948fd7d6509586df
Cr-Commit-Position: refs/heads/master@{#420963}

Powered by Google App Engine
This is Rietveld 408576698