third_party/WebKit/Source/core/dom/Text.cpp - Issue 2369963005: Avoid creating consecutive whitespace renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Text.cpp

Issue 2369963005: Avoid creating consecutive whitespace renderers. (Closed)

Patch Set: Rebased and manually fixed expectations Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Text.cpp

diff --git a/third_party/WebKit/Source/core/dom/Text.cpp b/third_party/WebKit/Source/core/dom/Text.cpp

index 89d8f9b7e117e18cf10bf07a05200ee52fc68cca..7e5f6d230874ef0cc85fc35180835d43d8e67084 100644

--- a/third_party/WebKit/Source/core/dom/Text.cpp

+++ b/third_party/WebKit/Source/core/dom/Text.cpp

@@ -294,6 +294,8 @@ bool Text::textLayoutObjectIsNeeded(const ComputedStyle& style, const LayoutObje

const LayoutObject* prev = LayoutTreeBuilderTraversal::previousSiblingLayoutObject(*this);

if (prev && prev->isBR()) // <span><br/> <br/></span>

return false;

+ if (prev && prev->isText() && prev->node()->isTextNode() && toText(prev->node())->containsOnlyWhitespace())

+ return false;

if (parent.isLayoutInline()) {

// <span><div/> <div/></span>