[base] Remove PointersMatch, making a separate std::equals hashmap

test/cctest/test-hashmap.cc

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 16 matching lines @@
 
 #include <stdlib.h>
 
 #include "src/v8.h"
 #include "test/cctest/cctest.h"
 
 #include "src/base/hashmap.h"
 
 using namespace v8::internal;
 
-static bool DefaultMatchFun(void* a, void* b) {
-  return a == b;
-}
-
 
 typedef uint32_t (*IntKeyHash)(uint32_t key);
 
 
 class IntSet {
  public:
-  explicit IntSet(IntKeyHash hash) : hash_(hash), map_(DefaultMatchFun)  {}
+  explicit IntSet(IntKeyHash hash) : hash_(hash), map_() {}

[marja, 2016/09/30 10:27:33]

Ditto

[Leszek Swirski, 2016/09/30 10:44:28]

Done.

 
   void Insert(int x) {
     CHECK_NE(0, x);  // 0 corresponds to (void*)NULL - illegal key value
     v8::base::HashMap::Entry* p =
         map_.LookupOrInsert(reinterpret_cast<void*>(x), hash_(x));
     CHECK(p != NULL);  // insert is set!
     CHECK_EQ(reinterpret_cast<void*>(x), p->key);
     // we don't care about p->value
   }
 
@@ skipping 112 matching lines @@
     }
   }
   CHECK_EQ(0u, set.occupancy());
 }
 
 
 TEST(HashSet) {
   TestSet(Hash, 100);
   TestSet(CollisionHash, 50);
 }