Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2369953002: [turbofan] Fix indirect escapes in escape analysis. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix indirect escapes in escape analysis. This makes sure we only replace load operations for fields on virtual objects. Even though data flow information for non-virtual (escaping) allocations is available, it might be inaccurate in certain situations where object state hasn't been cleared. R=jarin@chromium.org TEST=mjsunit/compiler/regress-escape-analysis-indirect Committed: https://crrev.com/437a33efd244f86a82e476135f4b0a77f11b83ad Cr-Commit-Position: refs/heads/master@{#39776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M src/compiler/escape-analysis-reducer.cc View 1 chunk +9 lines, -7 lines 0 comments Download
A + test/mjsunit/compiler/regress-escape-analysis-indirect.js View 1 chunk +9 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 2 months ago (2016-09-26 16:24:38 UTC) #3
Jarin
lgtm. Thanks!
4 years, 2 months ago (2016-09-27 14:35:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369953002/1
4 years, 2 months ago (2016-09-27 14:36:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 14:53:03 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 14:53:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/437a33efd244f86a82e476135f4b0a77f11b83ad
Cr-Commit-Position: refs/heads/master@{#39776}

Powered by Google App Engine
This is Rietveld 408576698