Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2369933006: Fix sanitizer_options_link_helper for iOS. (Closed)

Created:
4 years, 2 months ago by mef
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix sanitizer_options_link_helper for iOS. Committed: https://crrev.com/9b66238c85080ad1e15a5080a79ba6253e3c16b6 Cr-Commit-Position: refs/heads/master@{#421306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/sanitizers/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mef
Hi Dirk, PTAL, this is needed to make ASAN builds for iOS (simulator).
4 years, 2 months ago (2016-09-27 18:04:02 UTC) #2
Dirk Pranke
lgtm
4 years, 2 months ago (2016-09-27 18:38:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369933006/1
4 years, 2 months ago (2016-09-27 18:40:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 19:54:15 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 19:57:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b66238c85080ad1e15a5080a79ba6253e3c16b6
Cr-Commit-Position: refs/heads/master@{#421306}

Powered by Google App Engine
This is Rietveld 408576698