Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2369923003: Fix assert with distiller code caused by r419635. (Closed)

Created:
4 years, 2 months ago by jam
Modified:
4 years, 2 months ago
Reviewers:
mdjones
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix assert with distiller code caused by r419635. The change had a bug because previously WebContentsObserver::DidNavigateMainFrame was listened to which is only called for main frame successful navigations. It was switched to WebContentsObserver::DidFinishNavigation so that it can work with PlzNavigate. However that method is called in more situations, so restrict it to maintain the old behavior. BUG=650472 Committed: https://crrev.com/eeadd3b103a7e13ffb61b630551fc1d92967d8ae Cr-Commit-Position: refs/heads/master@{#421233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/dom_distiller/content/browser/dom_distiller_viewer_source.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jam
I don't have an Android device setup currently, do you mean verifying if this fixes ...
4 years, 2 months ago (2016-09-27 05:56:49 UTC) #5
mdjones
On 2016/09/27 05:56:49, jam wrote: > I don't have an Android device setup currently, do ...
4 years, 2 months ago (2016-09-27 15:22:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369923003/1
4 years, 2 months ago (2016-09-27 16:32:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 16:37:54 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 16:39:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eeadd3b103a7e13ffb61b630551fc1d92967d8ae
Cr-Commit-Position: refs/heads/master@{#421233}

Powered by Google App Engine
This is Rietveld 408576698