Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2369903002: [tools] Run callstats.py with --enable-benchmarking (Closed)

Created:
4 years, 2 months ago by Camillo Bruni
Modified:
4 years, 2 months ago
Reviewers:
nickie
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Run callstats.py with --enable-benchmarking Without --enable-benchmarking we might get flaky results due to active finch experiments. BUG= NOTRY=true Committed: https://crrev.com/381aa94d37d01293c1a92512514418b075367a0b Cr-Commit-Position: refs/heads/master@{#39752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/callstats.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Camillo Bruni
PTAL yet another micro change :)
4 years, 2 months ago (2016-09-26 12:19:35 UTC) #2
nickie
lgtm
4 years, 2 months ago (2016-09-26 12:21:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369903002/1
4 years, 2 months ago (2016-09-27 07:59:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 08:02:18 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 08:02:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/381aa94d37d01293c1a92512514418b075367a0b
Cr-Commit-Position: refs/heads/master@{#39752}

Powered by Google App Engine
This is Rietveld 408576698