src/interpreter/mkpeephole.cc - Issue 2369873002: [Interpreter] Replace BytecodeRegisterAllocator with a simple bump pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/mkpeephole.cc

Issue 2369873002: [Interpreter] Replace BytecodeRegisterAllocator with a simple bump pointer. (Closed)

Patch Set: Add dcheck Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/mkpeephole.cc

diff --git a/src/interpreter/mkpeephole.cc b/src/interpreter/mkpeephole.cc

index 8e9d5fea478fa74335e9d24a9c571a6ef2fe7638..270fe83ef9c3a7dcb59d76d6d559f8a0f78be523 100644

--- a/src/interpreter/mkpeephole.cc

+++ b/src/interpreter/mkpeephole.cc

@@ -146,6 +146,9 @@ PeepholeActionAndData PeepholeActionTableWriter::LookupActionAndData(

Bytecode::kIllegal};

}

+ // TODO(rmcilroy): Add elide for consecutive mov to and from the same

+ // register.

// Remove ToBoolean coercion from conditional jumps where possible.

if (Bytecodes::WritesBooleanToAccumulator(last)) {

if (Bytecodes::IsJumpIfToBoolean(current)) {