Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2369863002: [tools] Revert callstats.py group regexp changes (Closed)

Created:
4 years, 2 months ago by Camillo Bruni
Modified:
4 years, 2 months ago
Reviewers:
nickie
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Revert callstats.py group regexp changes The previous change accidentally shifted categories around which broke our performance graphs. BUG= Committed: https://crrev.com/248b7a08b4394550c6169c47f2e168c2d0291c44 Cr-Commit-Position: refs/heads/master@{#39721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/callstats.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Camillo Bruni
PTAL
4 years, 2 months ago (2016-09-26 09:06:05 UTC) #2
nickie
LGTM. (Now, the previous CL also LGTM, so go figure...)
4 years, 2 months ago (2016-09-26 09:19:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369863002/1
4 years, 2 months ago (2016-09-26 12:16:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 13:06:39 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 13:06:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/248b7a08b4394550c6169c47f2e168c2d0291c44
Cr-Commit-Position: refs/heads/master@{#39721}

Powered by Google App Engine
This is Rietveld 408576698