HTML parser: implementing throw-on-dynamic-markup-insertion counter

HTML parser: implementing throw-on-dynamic-markup-insertion counter

https://html.spec.whatwg.org/#throw-on-dynamic-markup-insertion-counter

Custom Element constructor should not be able to use document.write(),
document.open(), document.close().
https://html.spec.whatwg.org/#dom-document-write
https://html.spec.whatwg.org/#dom-document-open
https://html.spec.whatwg.org/#dom-document-close

Throw-on-dynamic-markup-insertion count is incremented/decremented in
create an element for the token algorithm.
https://html.spec.whatwg.org/#create-an-element-for-the-token

Layout test changes:
Custom Element constructor should not use document.write(), for both
"destructive" and "non-destructive" writes.

BUG=647586
Committed: https://crrev.com/89a6eed72ae35c6219934b7a11b61dfc60819b97
Cr-Commit-Position: refs/heads/master@{#422042}

[davaajav, 2016-09-26 07:41:10]

davaajav@google.com changed reviewers:
+ dominicc@chromium.org, kojii@chromium.org

[davaajav, 2016-09-26 07:41:11]

PTL

[davaajav, 2016-09-26 07:53:31]

The CQ bit was checked by davaajav@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 07:53:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davaajav, 2016-09-26 07:54:01]

The CQ bit was unchecked by davaajav@google.com

[davaajav, 2016-09-26 07:54:12]

The CQ bit was checked by davaajav@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 07:54:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davaajav, 2016-09-26 08:13:03]

The CQ bit was unchecked by davaajav@google.com

[davaajav, 2016-09-26 08:18:16]

The CQ bit was checked by davaajav@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 08:18:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 08:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 08:35:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davaajav, 2016-09-27 01:48:02]

The CQ bit was checked by davaajav@google.com to run a CQ dry run

[davaajav, 2016-09-27 01:48:09]

The CQ bit was unchecked by davaajav@google.com

[davaajav, 2016-09-27 01:48:29]

The CQ bit was checked by davaajav@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 01:49:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 02:57:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 02:57:23]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[davaajav, 2016-09-27 04:29:56]

The CQ bit was checked by davaajav@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 04:30:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 06:01:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 06:02:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dominicc (has gone to gerrit), 2016-09-28 08:01:03]

Very nice; some comments and questions inline.

https://codereview.chromium.org/2369853002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/custom-elements/spec/parsing.html (right):

https://codereview.chromium.org/2369853002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/custom-elements/spec/parsing.html:128: // throws
"InvalidStateError"DOMException.
Space before D

https://codereview.chromium.org/2369853002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/2369853002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.cpp:2292:
ExecutionContext::notifyContextDestroyed();
Just curious--why did you move this?

https://codereview.chromium.org/2369853002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Document.h (right):

https://codereview.chromium.org/2369853002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Document.h:1299: unsigned
m_throwOnDynamicMarkupInsertionCount;
Maybe add a link to this in the spec, like ignoreDestructiveWrites has?

https://codereview.chromium.org/2369853002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/dom/ThrowOnDynamicMarkupInsertionCountIncrementer.h
(right):

https://codereview.chromium.org/2369853002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/ThrowOnDynamicMarkupInsertionCountIncrementer.h:1:
/*
This is a new file, so put a new copyright notice with the current year. I think
the chromium.org style guide has an example. It's more succinct now.

https://codereview.chromium.org/2369853002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/ThrowOnDynamicMarkupInsertionCountIncrementer.h:38:
explicit ThrowOnDynamicMarkupInsertionCountIncrementer(Document* document)
Why not make this Document&?

[dominicc (has gone to gerrit), 2016-09-28 08:01:16]

dominicc@chromium.org changed reviewers:
+ domenic@chromium.org

[dominicc (has gone to gerrit), 2016-09-28 08:01:22]

dominicc@chromium.org changed reviewers:
- domenic@chromium.org

[dominicc (has gone to gerrit), 2016-09-28 08:01:23]

+domenic FYI

[davaajav, 2016-09-29 07:39:40]

PTL

https://codereview.chromium.org/2369853002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/dom/ThrowOnDynamicMarkupInsertionCountIncrementer.h
(right):

https://codereview.chromium.org/2369853002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/ThrowOnDynamicMarkupInsertionCountIncrementer.h:38:
explicit ThrowOnDynamicMarkupInsertionCountIncrementer(Document* document)
This seems to be the best way to do it

[davaajav, 2016-09-29 09:53:35]

The CQ bit was checked by davaajav@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 09:54:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 11:32:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 11:32:32]

Dry run: This issue passed the CQ dry run.

[dominicc (has gone to gerrit), 2016-09-30 04:51:03]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2016-09-30 04:51:04]

lgtm

[commit-bot: I haz the power, 2016-09-30 04:51:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 06:21:35]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-30 06:22:55]

Description was changed from

==========
HTML parser: implementing throw-on-dynamic-markup-insertion counter

https://html.spec.whatwg.org/#throw-on-dynamic-markup-insertion-counter

Custom Element constructor should not be able to use document.write(),
document.open(), document.close().
https://html.spec.whatwg.org/#dom-document-write
https://html.spec.whatwg.org/#dom-document-open
https://html.spec.whatwg.org/#dom-document-close

Throw-on-dynamic-markup-insertion count is incremented/decremented in
create an element for the token algorithm.
https://html.spec.whatwg.org/#create-an-element-for-the-token

Layout test changes:
Custom Element constructor should not use document.write(), for both
"destructive" and "non-destructive" writes.

BUG=647586
==========

to

==========
HTML parser: implementing throw-on-dynamic-markup-insertion counter

https://html.spec.whatwg.org/#throw-on-dynamic-markup-insertion-counter

Custom Element constructor should not be able to use document.write(),
document.open(), document.close().
https://html.spec.whatwg.org/#dom-document-write
https://html.spec.whatwg.org/#dom-document-open
https://html.spec.whatwg.org/#dom-document-close

Throw-on-dynamic-markup-insertion count is incremented/decremented in
create an element for the token algorithm.
https://html.spec.whatwg.org/#create-an-element-for-the-token

Layout test changes:
Custom Element constructor should not use document.write(), for both
"destructive" and "non-destructive" writes.

BUG=647586

Committed: https://crrev.com/89a6eed72ae35c6219934b7a11b61dfc60819b97
Cr-Commit-Position: refs/heads/master@{#422042}
==========

[commit-bot: I haz the power, 2016-09-30 06:22:56]

Patchset 6 (id:??) landed as
https://crrev.com/89a6eed72ae35c6219934b7a11b61dfc60819b97
Cr-Commit-Position: refs/heads/master@{#422042}