Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2369833003: Settings/Oobe: Fix logic for network list item connecting text. (Closed)

Created:
4 years, 2 months ago by stevenjb
Modified:
4 years, 2 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings/Oobe: Fix logic for network list item connecting text. BUG=648536 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7779ae28ee36ff2858778d4e3420f6d29b5d59da Cr-Commit-Position: refs/heads/master@{#421234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ui/webui/resources/cr_elements/network/cr_network_list_item.js View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
stevenjb
4 years, 2 months ago (2016-09-26 20:27:17 UTC) #3
Alexander Alekseev
lgtm
4 years, 2 months ago (2016-09-26 20:30:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369833003/1
4 years, 2 months ago (2016-09-26 20:36:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148381)
4 years, 2 months ago (2016-09-26 22:05:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369833003/1
4 years, 2 months ago (2016-09-27 15:58:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 16:43:47 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 16:47:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7779ae28ee36ff2858778d4e3420f6d29b5d59da
Cr-Commit-Position: refs/heads/master@{#421234}

Powered by Google App Engine
This is Rietveld 408576698