Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 236983004: Move 'designMode' attribute from HTMLDocument to Document (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, watchdog-blink-watchlist_google.com, rwlbuis, abarth-chromium
Visibility:
Public.

Description

Move 'designMode' attribute from HTMLDocument to Document Move 'designMode' attribute from HTMLDocument to Document to comply with the specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#making-entire-documents-editable:-the-designmode-idl-attribute This is consistent with IE11, however, Firefox 28 still has the 'designMode' attribute on HTMLDocument. BUG=362955 TEST=fast/dom/Document/designMode-non-html.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171574

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
A + LayoutTests/fast/dom/Document/designMode-non-html.html View 1 1 chunk +5 lines, -4 lines 0 comments Download
A + LayoutTests/fast/dom/Document/designMode-non-html-expected.txt View 1 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/dom/Document.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +17 lines, -0 lines 0 comments Download
M Source/core/dom/Document.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLDocument.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDocument.cpp View 1 1 chunk +0 lines, -17 lines 0 comments Download
M Source/core/html/HTMLDocument.idl View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
6 years, 8 months ago (2014-04-14 16:09:41 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 8 months ago (2014-04-14 16:53:01 UTC) #2
tkent
lgtm
6 years, 8 months ago (2014-04-15 05:11:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/236983004/1
6 years, 8 months ago (2014-04-15 05:12:02 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 05:21:14 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/Document.idl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-15 05:21:15 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-15 14:04:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/236983004/20001
6 years, 8 months ago (2014-04-15 14:04:27 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 14:44:54 UTC) #9
Message was sent while issue was closed.
Change committed as 171574

Powered by Google App Engine
This is Rietveld 408576698