Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 236983002: Handlify Heap::AllocateJSArrayStorage and friends. (Closed)

Created:
6 years, 8 months ago by Michael Starzinger
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Handlify Heap::AllocateJSArrayStorage and friends. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20735

Patch Set 1 #

Patch Set 2 : Some more follow-up work. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -97 lines) Patch
M src/factory.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/factory.cc View 1 3 chunks +47 lines, -9 lines 0 comments Download
M src/heap.h View 1 3 chunks +0 lines, -21 lines 0 comments Download
M src/heap.cc View 1 3 chunks +0 lines, -67 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
lgtm.
6 years, 8 months ago (2014-04-14 12:42:18 UTC) #1
Michael Starzinger
6 years, 8 months ago (2014-04-14 13:53:19 UTC) #2
Yang
On 2014/04/14 13:53:19, Michael Starzinger wrote: lgtm.
6 years, 8 months ago (2014-04-14 13:54:51 UTC) #3
Michael Starzinger
6 years, 8 months ago (2014-04-14 16:05:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20735 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698