Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2369823002: MD History: Focus the search field on load without 'showing' it (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Focus the search field on load without 'showing' it This changes the behavior from the equivalent of clicking on the search bar to the equivalent of focusing it with the tab key. This is a subtle distinction, but the end result is that the search icon does not light up, and the search field will not animate open when resizing the window into narrow mode. This CL also changes the focus logic to trigger on the correct toolbar wide mode breakpoint, which fixes an issue where the search field wouldn't be focused at certain screen widths. BUG=642701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e7d06665341b4829160a8c615eae591b99df19ef Cr-Commit-Position: refs/heads/master@{#421453}

Patch Set 1 #

Patch Set 2 : Closure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M chrome/browser/resources/md_history/app.js View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/data/webui/md_history/history_toolbar_test.js View 3 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tsergeant
4 years, 2 months ago (2016-09-27 00:35:27 UTC) #7
calamity
lgtm
4 years, 2 months ago (2016-09-28 02:37:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369823002/20001
4 years, 2 months ago (2016-09-28 02:53:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 05:12:03 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 05:15:10 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e7d06665341b4829160a8c615eae591b99df19ef
Cr-Commit-Position: refs/heads/master@{#421453}

Powered by Google App Engine
This is Rietveld 408576698