Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Issue 2369813002: Don't depend on unregisterProperty in register-property-syntax-parsing.html (Closed)

Created:
4 years, 2 months ago by Timothy Loh
Modified:
4 years, 2 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't depend on unregisterProperty in register-property-syntax-parsing.html It sounds like unregisterProperty will be removed from the first version of the P&V API, so let's not depend on it in our test. BUG=641877 Committed: https://crrev.com/ad7e45054466325ed927146b20edfe976f80c608 Cr-Commit-Position: refs/heads/master@{#421104}

Patch Set 1 #

Patch Set 2 : fix expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/custom-properties/register-property-syntax-parsing.html View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/custom-properties/register-property-syntax-parsing-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Timothy Loh
Also removes the empty catch block you didn't like :)
4 years, 2 months ago (2016-09-26 04:16:30 UTC) #4
meade_UTC10
lgtm
4 years, 2 months ago (2016-09-27 04:31:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369813002/20001
4 years, 2 months ago (2016-09-27 04:32:44 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 04:41:09 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 04:42:51 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad7e45054466325ed927146b20edfe976f80c608
Cr-Commit-Position: refs/heads/master@{#421104}

Powered by Google App Engine
This is Rietveld 408576698