Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 23697002: Implement proper map checks of captured objects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Toon Verwaest. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-x64.h ('k') | test/mjsunit/compiler/escape-analysis.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1905 matching lines...) Expand 10 before | Expand all | Expand 10 after
1916 } 1916 }
1917 1917
1918 1918
1919 LInstruction* LChunkBuilder::DoCheckInstanceType(HCheckInstanceType* instr) { 1919 LInstruction* LChunkBuilder::DoCheckInstanceType(HCheckInstanceType* instr) {
1920 LOperand* value = UseRegisterAtStart(instr->value()); 1920 LOperand* value = UseRegisterAtStart(instr->value());
1921 LCheckInstanceType* result = new(zone()) LCheckInstanceType(value); 1921 LCheckInstanceType* result = new(zone()) LCheckInstanceType(value);
1922 return AssignEnvironment(result); 1922 return AssignEnvironment(result);
1923 } 1923 }
1924 1924
1925 1925
1926 LInstruction* LChunkBuilder::DoCheckFunction(HCheckFunction* instr) { 1926 LInstruction* LChunkBuilder::DoCheckValue(HCheckValue* instr) {
1927 LOperand* value = UseRegisterAtStart(instr->value()); 1927 LOperand* value = UseRegisterAtStart(instr->value());
1928 return AssignEnvironment(new(zone()) LCheckFunction(value)); 1928 return AssignEnvironment(new(zone()) LCheckValue(value));
1929 } 1929 }
1930 1930
1931 1931
1932 LInstruction* LChunkBuilder::DoCheckMaps(HCheckMaps* instr) { 1932 LInstruction* LChunkBuilder::DoCheckMaps(HCheckMaps* instr) {
1933 LOperand* value = NULL; 1933 LOperand* value = NULL;
1934 if (!instr->CanOmitMapChecks()) { 1934 if (!instr->CanOmitMapChecks()) {
1935 value = UseRegisterAtStart(instr->value()); 1935 value = UseRegisterAtStart(instr->value());
1936 if (instr->has_migration_target()) info()->MarkAsDeferredCalling(); 1936 if (instr->has_migration_target()) info()->MarkAsDeferredCalling();
1937 } 1937 }
1938 LCheckMaps* result = new(zone()) LCheckMaps(value); 1938 LCheckMaps* result = new(zone()) LCheckMaps(value);
(...skipping 577 matching lines...) Expand 10 before | Expand all | Expand 10 after
2516 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2516 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2517 LOperand* object = UseRegister(instr->object()); 2517 LOperand* object = UseRegister(instr->object());
2518 LOperand* index = UseTempRegister(instr->index()); 2518 LOperand* index = UseTempRegister(instr->index());
2519 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2519 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2520 } 2520 }
2521 2521
2522 2522
2523 } } // namespace v8::internal 2523 } } // namespace v8::internal
2524 2524
2525 #endif // V8_TARGET_ARCH_X64 2525 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-x64.h ('k') | test/mjsunit/compiler/escape-analysis.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698