Shapedetection module: Blink side implementation

third_party/WebKit/public/platform/modules/shapedetection/shapedetection.mojom

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module blink.mojom;
+
+// BoundingBox is defined with its upper-left point, width and height. It is
+// essentially the same as DOMRect, but needs explicit conversion in blink.
+struct BoundingBox {

[Ken Rockot(use gerrit already), 2016/09/30 18:05:24]

Note that ui/gfx/geometry/mojo/geometry.mojom already defines some standard
rectangle types (Rect for ints and RectF for floats.) I think we should avoid
introducing more in blink mojom.

You can

import "ui/gfx/geomoetry/mojo/geometry.mojom";

in this file and your message can return an array<gfx.mojom.RectF> instead.

The bindings target will then also need a public_deps on //ui/gfx/geometry/mojo.

[xianglu, 2016/10/03 18:12:07]

Done.

+    double x;
+    double y;
+    double width;
+    double height;
+};
+
+// https://wicg.github.io/shape-detection-api/#api
+interface ShapeDetection {
+    DetectFace(handle<shared_buffer> frame_data, uint32 width, uint32 height) => (array<BoundingBox> boundingBoxes);

[Ken Rockot(use gerrit already), 2016/09/30 18:05:24]

nit: Please document the format of frame_data. Specifically it's important to
convey the pixel format, the row/column ordering, and that the data is tightly
packed, since all of these things frequently vary in image buffer formats.

[xianglu, 2016/10/03 18:12:08]

Done.

+};