Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2369683002: Revert of Move language pak files to assets. (Closed)

Created:
4 years, 2 months ago by Khushal
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move language pak files to assets. (patchset #13 id:240001 of https://codereview.chromium.org/2345143002/ ) Reason for revert: Broke the internal build, https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/instrumentation-mako-clankium-tot/builds/10008 Original issue's description: > Move language pak files to assets. > > Language pak files were moved to res/raw when split apks was being implemented. > Moving them to assets with a java constant keeping track of pak file locations > will improve lookup time and save some space (no more xml files and > resources.arsc). > > BUG=529604 > > Committed: https://crrev.com/34ae27889dd8c8ffd5f5ca8c7bc10c17e57c12e2 > Cr-Commit-Position: refs/heads/master@{#420641} TBR=agrieve@chromium.org,michaelbai@chromium.org,nyquist@chromium.org,tedchoc@chromium.org,estevenson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=529604 Committed: https://crrev.com/32fceb36f0e9129cf6022e3aac344fd601144df7 Cr-Commit-Position: refs/heads/master@{#420791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -231 lines) Patch
M android_webview/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M android_webview/glue/BUILD.gn View 1 chunk +2 lines, -8 lines 0 comments Download
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 3 chunks +2 lines, -2 lines 0 comments Download
M android_webview/system_webview_apk_tmpl.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/test/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java View 2 chunks +2 lines, -2 lines 0 comments Download
M base/android/java/src/org/chromium/base/LocaleUtils.java View 2 chunks +2 lines, -12 lines 0 comments Download
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 3 chunks +22 lines, -6 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpApplication.java View 1 chunk +1 line, -1 line 0 comments Download
D build/android/gyp/locale_pak_assets.py View 1 chunk +0 lines, -104 lines 0 comments Download
A build/android/gyp/locale_pak_resources.py View 1 chunk +126 lines, -0 lines 0 comments Download
M build/android/gyp/write_build_config.py View 4 chunks +21 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +7 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 5 chunks +73 lines, -59 lines 0 comments Download
M chrome/android/BUILD.gn View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ResourceBundle.java View 3 chunks +45 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Khushal
Created Revert of Move language pak files to assets.
4 years, 2 months ago (2016-09-23 23:52:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369683002/1
4 years, 2 months ago (2016-09-23 23:53:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-23 23:54:19 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/32fceb36f0e9129cf6022e3aac344fd601144df7 Cr-Commit-Position: refs/heads/master@{#420791}
4 years, 2 months ago (2016-09-23 23:55:57 UTC) #6
agrieve
4 years, 2 months ago (2016-09-26 18:19:30 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2371843002/ by agrieve@chromium.org.

The reason for reverting is: Will update once changed..

Powered by Google App Engine
This is Rietveld 408576698