Wire NQE Prefs to Profile

net/nqe/network_id.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_NQE_NETWORK_ID_H_
 #define NET_NQE_NETWORK_ID_H_
 
 #include <string>
 #include <tuple>
 
 #include "net/base/net_export.h"
 #include "net/base/network_change_notifier.h"
 
 namespace {
 const char kValueSeparator[] = ",";
 }
 
 namespace net {
 namespace nqe {
 namespace internal {
 
 // NetworkID is used to uniquely identify a network.
 // For the purpose of network quality estimation and caching, a network is
 // uniquely identified by a combination of |type| and
 // |id|. This approach is unable to distinguish networks with
 // same name (e.g., different Wi-Fi networks with same SSID).
 // This is a protected member to expose it to tests.
 struct NET_EXPORT_PRIVATE NetworkID {
+  static NetworkID FromString(const std::string& network_id) {
+    size_t separator_index = network_id.find(kValueSeparator);
+    DCHECK_NE(std::string::npos, separator_index);
+    if (separator_index == std::string::npos) {
+      return NetworkID(NetworkChangeNotifier::CONNECTION_UNKNOWN,
+                       std::string());
+    }
+    return NetworkID(NetworkChangeNotifier::StringToConnectionType(
+                         network_id.substr(separator_index + 1)),
+                     network_id.substr(0, separator_index));
+  }
   NetworkID(NetworkChangeNotifier::ConnectionType type, const std::string& id)
       : type(type), id(id) {}
   NetworkID(const NetworkID& other) : type(other.type), id(other.id) {}
   ~NetworkID() {}
 
+  bool operator==(const NetworkID& other) const {
+    return type == other.type && id == other.id;
+  }
+
+  bool operator!=(const NetworkID& other) const {
+    return type != other.type || id != other.id;

[RyanSturm, 2016/10/12 21:33:34]

maybe something like this:

return !operator==(other);

[tbansal1, 2016/10/12 22:04:01]

Done.

+  }
+
   NetworkID& operator=(const NetworkID& other) {
     type = other.type;
     id = other.id;
     return *this;
   }
 
   // Overloaded to support ordered collections.
   bool operator<(const NetworkID& other) const {
     return std::tie(type, id) < std::tie(other.type, other.id);
   }
@@ skipping 15 matching lines @@
   // - An empty string in all other cases or if the network name is not
   //   exposed by platform APIs.
   std::string id;
 };
 
 }  // namespace internal
 }  // namespace nqe
 }  // namespace net
 
 #endif  // NET_NQE_NETWORK_QUALITY_ESTIMATOR_H_