[Material][Mac] Update User Account Button

[Material][Mac] Change the User Account Text Color

- Fix the User Account text colors:
  - For themed windows, the text color should be the same as the
   selected tab's title
  - In Guest Mode, the text color should only be white if the browser is
  not using MD

BUG=646060, 648890
Committed: https://crrev.com/28f2ba5dd2bd96becc57e5caf9447e7ce65db96b
Cr-Commit-Position: refs/heads/master@{#423060}

[spqchan, 2016-09-23 23:49:49]

Description was changed from

==========
[Material][Mac] Change the User Account Text Color

- If the window is themed, the user button account should have the
 same tab text color
-

BUG=
==========

to

==========
[Material][Mac] Change the User Account Text Color

- For themed windows, the text color should be the same as the
   selected tab's title
- In Guest Mode, the text color should only be white if the browser is
  not using MD

BUG=646060,648890
==========

[spqchan, 2016-09-23 23:49:49]

spqchan@chromium.org changed reviewers:
+ shrike@chromium.org

[spqchan, 2016-09-23 23:49:59]

PTAL

[shrike, 2016-09-27 19:13:06]

This looks good, except that the button text color does not seem to change when
you change themes. For example, I launched with a dark theme that had white tab
text, and then switched to a dark theme that had black tab text. After the
switch, the tab text was black, but the button text was still white.

[spqchan, 2016-09-28 17:13:32]

On 2016/09/27 19:13:06, shrike wrote:
> This looks good, except that the button text color does not seem to change
when
> you change themes. For example, I launched with a dark theme that had white
tab
> text, and then switched to a dark theme that had black tab text. After the
> switch, the tab text was black, but the button text was still white.

Good catch, I made the fix

[shrike, 2016-09-28 18:26:47]

lgtm

Note that ui::MaterialDesignController::IsModeMaterial() now always returns
true, so you don't need to maintain the pre-Material style.

[spqchan, 2016-09-28 18:55:16]

On 2016/09/28 18:26:47, shrike wrote:
> lgtm
> 
> Note that ui::MaterialDesignController::IsModeMaterial() now always returns
> true, so you don't need to maintain the pre-Material style.

Oh wow, looks like it's time for a massive clean up all over the codebase :)
Thanks for the heads up, I'll remove everything non Material related

[spqchan, 2016-09-28 19:21:50]

Description was changed from

==========
[Material][Mac] Change the User Account Text Color

- For themed windows, the text color should be the same as the
   selected tab's title
- In Guest Mode, the text color should only be white if the browser is
  not using MD

BUG=646060,648890
==========

to

==========
[Material][Mac] Change the User Account Text Color

- Remove Non-MD code
- Fix the User Account text colors:
  - For themed windows, the text color should be the same as the
   selected tab's title
  - In Guest Mode, the text color should only be white if the browser is
  not using MD

BUG=646060,648890
==========

[spqchan, 2016-09-28 19:46:04]

On 2016/09/28 18:55:16, spqchan wrote:
> On 2016/09/28 18:26:47, shrike wrote:
> > lgtm
> > 
> > Note that ui::MaterialDesignController::IsModeMaterial() now always returns
> > true, so you don't need to maintain the pre-Material style.
> 
> Oh wow, looks like it's time for a massive clean up all over the codebase :)
> Thanks for the heads up, I'll remove everything non Material related

Hey Jayson, can you have another pass at this? I removed the non-MD stuff and
cleaned up the code.
Can you check if this looks alright? Thanks!

[shrike, 2016-09-28 21:35:30]

https://codereview.chromium.org/2369663002/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm (right):

https://codereview.chromium.org/2369663002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm:226: : [NSColor
blackColor];
Seems like you still need to handle the case where
browser_->profile()->IsGuestSession()?

[spqchan, 2016-09-28 21:39:36]

PTAL

https://codereview.chromium.org/2369663002/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm (right):

https://codereview.chromium.org/2369663002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm:226: : [NSColor
blackColor];
On 2016/09/28 21:35:30, shrike wrote:
> Seems like you still need to handle the case where
> browser_->profile()->IsGuestSession()?

I don't think that's necessary since Guest Sessions don't use themes.
If they do end up using themes though, I think the correct color would be the
tab text color

[shrike, 2016-09-28 23:58:50]

https://codereview.chromium.org/2369663002/diff/80001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm (right):

https://codereview.chromium.org/2369663002/diff/80001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm:226: : [NSColor
blackColor];
On 2016/09/28 21:39:36, spqchan wrote:
> I don't think that's necessary since Guest Sessions don't use themes.
> If they do end up using themes though, I think the correct color would be the
> tab text color

The only thing is the text is drawn specially (in white) when you're in guest
mode, to indicate you are in guest mode. In theory you could have an account
named Guest, and if guest mode draws the title in black or the tab title color
you will never know if you're in Guest mode or the Guest account.

I don't think drawing the text in white is the answer either. Can you explain
the situation with the guest button to sgabriel@ or bettes@ and ask what we
should be doing with the text?

[spqchan, 2016-09-29 00:12:47]

On 2016/09/28 23:58:50, shrike wrote:
>
https://codereview.chromium.org/2369663002/diff/80001/chrome/browser/ui/cocoa...
> File chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm (right):
> 
>
https://codereview.chromium.org/2369663002/diff/80001/chrome/browser/ui/cocoa...
> chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm:226: : [NSColor
> blackColor];
> On 2016/09/28 21:39:36, spqchan wrote:
> > I don't think that's necessary since Guest Sessions don't use themes.
> > If they do end up using themes though, I think the correct color would be
the
> > tab text color
> 
> The only thing is the text is drawn specially (in white) when you're in guest
> mode, to indicate you are in guest mode. In theory you could have an account
> named Guest, and if guest mode draws the title in black or the tab title color
> you will never know if you're in Guest mode or the Guest account.
> 
> I don't think drawing the text in white is the answer either. Can you explain
> the situation with the guest button to sgabriel@ or bettes@ and ask what we
> should be doing with the text?

Done

[spqchan, 2016-09-30 01:36:47]

Description was changed from

==========
[Material][Mac] Change the User Account Text Color

- Remove Non-MD code
- Fix the User Account text colors:
  - For themed windows, the text color should be the same as the
   selected tab's title
  - In Guest Mode, the text color should only be white if the browser is
  not using MD

BUG=646060,648890
==========

to

==========
[Material][Mac] Change the User Account Text Color

- Fix the User Account text colors:
  - For themed windows, the text color should be the same as the
   selected tab's title
  - In Guest Mode, the text color should only be white if the browser is
  not using MD

BUG=646060,648890
==========

[spqchan, 2016-10-03 18:39:02]

On 2016/09/29 00:12:47, spqchan wrote:
> On 2016/09/28 23:58:50, shrike wrote:
> >
>
https://codereview.chromium.org/2369663002/diff/80001/chrome/browser/ui/cocoa...
> > File chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm (right):
> > 
> >
>
https://codereview.chromium.org/2369663002/diff/80001/chrome/browser/ui/cocoa...
> > chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm:226: : [NSColor
> > blackColor];
> > On 2016/09/28 21:39:36, spqchan wrote:
> > > I don't think that's necessary since Guest Sessions don't use themes.
> > > If they do end up using themes though, I think the correct color would be
> the
> > > tab text color
> > 
> > The only thing is the text is drawn specially (in white) when you're in
guest
> > mode, to indicate you are in guest mode. In theory you could have an account
> > named Guest, and if guest mode draws the title in black or the tab title
color
> > you will never know if you're in Guest mode or the Guest account.
> > 
> > I don't think drawing the text in white is the answer either. Can you
explain
> > the situation with the guest button to sgabriel@ or bettes@ and ask what we
> > should be doing with the text?
> 
> Done

Talked to shrike and bettes off thread. The guest color should be black for now
in MD.
The non-MD code will be removed in a follow up CL since this one needs to be
merged to M54.

[spqchan, 2016-10-03 18:39:30]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org

[spqchan, 2016-10-03 18:39:31]

+avi for OWNER

[spqchan, 2016-10-05 01:37:37]

On 2016/10/03 18:39:31, spqchan wrote:
> +avi for OWNER

ping

[Avi (use Gerrit), 2016-10-05 02:20:40]

apologies; lgtm

[spqchan, 2016-10-05 02:28:55]

On 2016/10/05 02:20:40, Avi wrote:
> apologies; lgtm

no worries, thanks!

[spqchan, 2016-10-05 02:28:59]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-10-05 02:28:59]

The patchset sent to the CQ was uploaded after l-g-t-m from shrike@chromium.org
Link to the patchset: https://codereview.chromium.org/2369663002/#ps100001
(title: "Added back the MD checks and non MD stuff")

[commit-bot: I haz the power, 2016-10-05 02:29:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 03:05:55]

Description was changed from

==========
[Material][Mac] Change the User Account Text Color

- Fix the User Account text colors:
  - For themed windows, the text color should be the same as the
   selected tab's title
  - In Guest Mode, the text color should only be white if the browser is
  not using MD

BUG=646060,648890
==========

to

==========
[Material][Mac] Change the User Account Text Color

- Fix the User Account text colors:
  - For themed windows, the text color should be the same as the
   selected tab's title
  - In Guest Mode, the text color should only be white if the browser is
  not using MD

BUG=646060,648890
==========

[commit-bot: I haz the power, 2016-10-05 03:05:55]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-05 03:07:56]

Description was changed from

==========
[Material][Mac] Change the User Account Text Color

- Fix the User Account text colors:
  - For themed windows, the text color should be the same as the
   selected tab's title
  - In Guest Mode, the text color should only be white if the browser is
  not using MD

BUG=646060,648890
==========

to

==========
[Material][Mac] Change the User Account Text Color

- Fix the User Account text colors:
  - For themed windows, the text color should be the same as the
   selected tab's title
  - In Guest Mode, the text color should only be white if the browser is
  not using MD

BUG=646060,648890

Committed: https://crrev.com/28f2ba5dd2bd96becc57e5caf9447e7ce65db96b
Cr-Commit-Position: refs/heads/master@{#423060}
==========

[commit-bot: I haz the power, 2016-10-05 03:07:57]

Patchset 6 (id:??) landed as
https://crrev.com/28f2ba5dd2bd96becc57e5caf9447e7ce65db96b
Cr-Commit-Position: refs/heads/master@{#423060}