Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issue 2369653002: [Sync] Try to fix PrecacheLauncher test flakiness. (Closed)

Created:
4 years, 3 months ago by maxbogue
Modified:
4 years, 2 months ago
Reviewers:
bengr
CC:
chromium-reviews, wifiprefetch-reviews_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Try to fix PrecacheLauncher test flakiness. Looks like ContextUtils was not always properly initialized with the application context. Successfully ran the tests 250+ times without getting a flake after this fix. BUG=648749 Committed: https://crrev.com/6bf21d2047f3e9b43ef1f9c6bb6257ef48d98758 Cr-Commit-Position: refs/heads/master@{#421369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java View 7 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
maxbogue
Ben, PTAL! It didn't end up being related to sync but it was pretty straightforward ...
4 years, 3 months ago (2016-09-23 23:33:16 UTC) #5
bengr
lgtm
4 years, 2 months ago (2016-09-27 22:02:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369653002/1
4 years, 2 months ago (2016-09-27 22:08:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 22:45:51 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 22:47:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bf21d2047f3e9b43ef1f9c6bb6257ef48d98758
Cr-Commit-Position: refs/heads/master@{#421369}

Powered by Google App Engine
This is Rietveld 408576698