Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 2369633002: Fix handling of co19 syntax error tests using the @compile-error tag and reload bots (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index d04015946cf292bf44560862d90d8fd5ebb7893c..cf6a1a05fbd4bae5108d92bcce161337a39810f4 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -302,7 +302,8 @@ abstract class TestSuite {
if (configuration['hot_reload'] || configuration['hot_reload_rollback']) {
// Handle reload special cases.
- if (expectations.contains(Expectation.COMPILETIME_ERROR)) {
+ if (expectations.contains(Expectation.COMPILETIME_ERROR) ||
+ testCase.hasCompileError || testCase.expectCompileError) {
// Running a test that expects a compilation error with hot reloading
// is redundant with a regular run of the test.
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698