third_party/WebKit/Source/web/tests/FrameTestHelpers.h - Issue 2369613003: Require WebLocalFrame to be created with a non-null client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

Issue 2369613003: Require WebLocalFrame to be created with a non-null client (Closed)

Patch Set: oops Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/ChromeClientImpl.cpp ('K') | « third_party/WebKit/Source/web/tests/FrameLoaderClientImplTest.cpp ('k') | third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp » ('j') | third_party/WebKit/public/web/WebFrameClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/FrameTestHelpers.h

diff --git a/third_party/WebKit/Source/web/tests/FrameTestHelpers.h b/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

index 523171dafb6967a1fe1768867df40dbd9305f182..4da105e8469a2d26257eafa08ebe94cd78c9da9a 100644

--- a/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

+++ b/third_party/WebKit/Source/web/tests/FrameTestHelpers.h

@@ -210,8 +210,7 @@ class TestWebFrameClient : public WebFrameClient {

public:

TestWebFrameClient();

- WebFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& name, const WebString& uniqueName, WebSandboxFlags, const WebFrameOwnerProperties&) override;

- void frameDetached(WebLocalFrame*, DetachType) override;

+ WebLocalFrame* createChildFrame(WebLocalFrame* parent, WebTreeScopeType, const WebString& name, const WebString& uniqueName, WebSandboxFlags, const WebFrameOwnerProperties&) override;

void didStartLoading(bool) override;

void didStopLoading() override;