third_party/WebKit/Source/core/loader/FrameLoader.cpp - Issue 2369613003: Require WebLocalFrame to be created with a non-null client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2369613003: Require WebLocalFrame to be created with a non-null client (Closed)

Patch Set: oops Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

index af4d71268aead1e1b8211453e5ba162035ffb0b9..08f9cceda9ae890eb34683c361f8f5bbd7d8e0dc 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

@@ -1115,7 +1115,7 @@ bool FrameLoader::prepareForCommit()

// frame on a detached DOM tree, which is bad.

SubframeLoadingDisabler disabler(m_frame->document());

if (m_documentLoader) {

- client()->dispatchWillClose();

+ client()->dispatchWillCommitProvisionalLoad();

dispatchUnloadEvent();

}

m_frame->detachChildren();