Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: extensions/renderer/scoped_web_frame.cc

Issue 2369613003: Require WebLocalFrame to be created with a non-null client (Closed)
Patch Set: oops Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/scoped_web_frame.cc
diff --git a/extensions/renderer/scoped_web_frame.cc b/extensions/renderer/scoped_web_frame.cc
index e2e011194cb51caeccc9eb9185f2c642d5cb8286..60066b3bc1501d515869813192235a138cd69c76 100644
--- a/extensions/renderer/scoped_web_frame.cc
+++ b/extensions/renderer/scoped_web_frame.cc
@@ -10,14 +10,13 @@ namespace extensions {
ScopedWebFrame::ScopedWebFrame() : view_(nullptr), frame_(nullptr) {
view_ = blink::WebView::create(nullptr, blink::WebPageVisibilityStateVisible);
- frame_ = blink::WebLocalFrame::create(
- blink::WebTreeScopeType::Document, nullptr);
+ frame_ = blink::WebLocalFrame::create(blink::WebTreeScopeType::Document,
+ &frame_client_);
view_->setMainFrame(frame_);
}
ScopedWebFrame::~ScopedWebFrame() {
view_->close();
- frame_->close();
blink::WebHeap::collectAllGarbageForTesting();
}

Powered by Google App Engine
This is Rietveld 408576698