Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/render_frame_impl.h

Issue 2369613003: Require WebLocalFrame to be created with a non-null client (Closed)
Patch Set: oops Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/printing/renderer/print_web_view_helper.cc ('K') | « content/renderer/media/android/media_info_loader_unittest.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 9523dbc4a089b87782057af8c1834e5cafadc8e2..2fb7787a75959bbfa30a640ac5b96a2f23265811 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -470,7 +470,7 @@ class CONTENT_EXPORT RenderFrameImpl
blink::BlameContext* frameBlameContext() override;
blink::WebServiceWorkerProvider* createServiceWorkerProvider() override;
void didAccessInitialDocument() override;
- blink::WebFrame* createChildFrame(
+ blink::WebLocalFrame* createChildFrame(
blink::WebLocalFrame* parent,
blink::WebTreeScopeType scope,
const blink::WebString& name,
@@ -480,7 +480,7 @@ class CONTENT_EXPORT RenderFrameImpl
void didChangeOpener(blink::WebFrame* frame) override;
void frameDetached(blink::WebLocalFrame* frame, DetachType type) override;
void frameFocused() override;
- void willClose(blink::WebFrame* frame) override;
+ void willCommitProvisionalLoad(blink::WebLocalFrame* frame) override;
void didChangeName(const blink::WebString& name,
const blink::WebString& unique_name) override;
void didEnforceInsecureRequestPolicy(
« components/printing/renderer/print_web_view_helper.cc ('K') | « content/renderer/media/android/media_info_loader_unittest.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698