Require WebLocalFrame to be created with a non-null client

components/plugins/renderer/webview_plugin.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/plugins/renderer/webview_plugin.h"
 
 #include <stddef.h>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 44 matching lines @@
       container_(nullptr),
       web_view_(WebView::create(this, blink::WebPageVisibilityStateVisible)),
       focused_(false),
       is_painting_(false),
       is_resizing_(false),
       web_frame_client_(this),
       weak_factory_(this) {
   // ApplyWebPreferences before making a WebLocalFrame so that the frame sees a
   // consistent view of our preferences.
   content::RenderView::ApplyWebPreferences(preferences, web_view_);
-  WebLocalFrame* web_local_frame = WebLocalFrame::create(
+  WebLocalFrame* web_frame = WebLocalFrame::create(
       blink::WebTreeScopeType::Document, &web_frame_client_);
-  web_frame_ = web_local_frame;
-  web_view_->setMainFrame(web_frame_);
+  web_view_->setMainFrame(web_frame);
   // TODO(dcheng): The main frame widget currently has a special case.
   // Eliminate this once WebView is no longer a WebWidget.
-  web_frame_widget_ = WebFrameWidget::create(this, web_view_, web_local_frame);
+  WebFrameWidget::create(this, web_view_, web_frame);
 }
 
 // static
 WebViewPlugin* WebViewPlugin::Create(content::RenderView* render_view,
                                      WebViewPlugin::Delegate* delegate,
                                      const WebPreferences& preferences,
                                      const std::string& html_data,
                                      const GURL& url) {
   DCHECK(url.is_valid()) << "Blink requires the WebView to have a valid URL.";
   WebViewPlugin* plugin = new WebViewPlugin(render_view, delegate, preferences);
   plugin->web_view()->mainFrame()->loadHTMLString(html_data, url);
   return plugin;
 }
 
 WebViewPlugin::~WebViewPlugin() {
   DCHECK(!weak_factory_.HasWeakPtrs());
-  web_frame_widget_->close();
   web_view_->close();
-  web_frame_->close();
 }
 
 WebPluginContainer* WebViewPlugin::container() const { return container_; }
 
 bool WebViewPlugin::initialize(WebPluginContainer* container) {
   DCHECK(container);
   DCHECK_EQ(this, container->plugin());
   container_ = container;
 
   // We must call layout again here to ensure that the container is laid
@@ skipping 212 matching lines @@
   if (!delegate_)
     return;
 
   // The delegate may instantiate a new plugin.
   delegate_->OnUnobscuredRectUpdate(gfx::Rect(unobscured_rect));
   // The delegate may have dirtied style and layout of the WebView.
   // See for example the resizePoster function in plugin_poster.html.
   // Run the lifecycle now so that it is clean.
   web_view_->updateAllLifecyclePhases();
 }