Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2369603002: Turn on CompositeOpaqueFixedPosition for test and rebase tests. (Closed)

Created:
4 years, 2 months ago by flackr
Modified:
4 years, 2 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on CompositeOpaqueFixedPosition for tests and rebase tests. BUG=626200 Committed: https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27 Cr-Commit-Position: refs/heads/master@{#425487}

Patch Set 1 #

Patch Set 2 : Rebase tests. #

Patch Set 3 : Rebaseline #

Patch Set 4 : Enable on tests only. #

Patch Set 5 : . #

Patch Set 6 : Trybot rebaselines #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-under-transform-expected.txt View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/deprecation/css-clip-and-clip-path.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/absolute-position-changed.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-with-abs-pos-child-scroll.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-scroll-in-empty-root-layer.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-scroll-in-empty-root-layer-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/filter-on-html-element-with-fixed-position-child.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-child-move-after-scroll.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-child-of-fixed-move-after-scroll.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-move-after-scroll.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-under-composited-absolute-scrolled.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-under-composited-fixed-scrolled.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/resources/repaint-with-scrollbar-change.html View 2 chunks +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/nested-render-surfaces-expected.png View 1 2 3 4 5 6 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/background-resize-height-expected.txt View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-move-after-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-move-after-scroll-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/filters/blur-filter-page-scroll-expected.png View 1 2 3 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/filters/blur-filter-page-scroll-parents-expected.png View 1 2 3 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-move-after-scroll-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-move-after-scroll-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png View 1 2 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/css3/filters/blur-filter-page-scroll-expected.png View 1 2 3 4 5 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/css3/filters/blur-filter-page-scroll-parents-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-move-after-scroll-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-move-after-scroll-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png View 1 2 3 4 5 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-expected.png View 1 2 3 4 5 6 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/blur-filter-page-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/blur-filter-page-scroll-parents-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/paint/invalidation/background-resize-height-expected.txt View 1 2 3 4 5 9 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-move-after-scroll-expected.png View 1 2 3 4 5 6 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png View 1 2 3 4 5 6 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-expected.png View 1 2 3 4 5 6 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-move-after-scroll-expected.png View 1 2 3 4 5 6 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/background-resize-height-expected.txt View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/data/fixed-position-losing-backing.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
flackr
Hey, This turns on CompositeOpaqueFixedPosition for tests. Unfortunately a lot of tests had opaque fixed ...
4 years, 2 months ago (2016-10-11 14:15:31 UTC) #3
Stephen Chennney
LGTM. Sorry for the delay.
4 years, 2 months ago (2016-10-12 20:34:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369603002/100001
4 years, 2 months ago (2016-10-12 20:51:34 UTC) #6
commit-bot: I haz the power
Exceeded global retry quota
4 years, 2 months ago (2016-10-12 23:02:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369603002/120001
4 years, 2 months ago (2016-10-14 21:23:17 UTC) #11
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 2 months ago (2016-10-14 22:06:13 UTC) #12
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/b497cdb2b02803980368504e2a361c5d48750f27 Cr-Commit-Position: refs/heads/master@{#425487}
4 years, 2 months ago (2016-10-14 22:09:38 UTC) #14
joedow
4 years, 2 months ago (2016-10-14 23:35:22 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2423643002/ by joedow@chromium.org.

The reason for reverting is: CL is suspected to be causing failures on multiple
mac builders:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1....

Powered by Google App Engine
This is Rietveld 408576698