Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Issue 2369573002: Add GN arg "enable_proguard_obfuscation" (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 2 months ago
Reviewers:
Ted C, estevenson
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GN arg "enable_proguard_obfuscation" This will give us an easy toggle for testing out obfuscation. BUG=620323 Committed: https://crrev.com/ba47c148cdccdb687d79991f306f36eeb9ee5d2e Cr-Commit-Position: refs/heads/master@{#420714}

Patch Set 1 #

Patch Set 2 : Add GN arg "enable_proguard_obfuscation" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M chrome/android/chrome_public_apk_tmpl.gni View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/android/java/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/proguard.flags View 1 chunk +3 lines, -14 lines 0 comments Download
A + chrome/android/java/proguard-dont-obfuscate.flags View 1 chunk +3 lines, -5 lines 0 comments Download
A chrome/android/java/proguard-obfuscate.flags View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
agrieve
4 years, 3 months ago (2016-09-23 19:14:08 UTC) #2
agrieve
tedchoc for OWNERS
4 years, 3 months ago (2016-09-23 19:15:36 UTC) #4
Ted C
lgtm
4 years, 3 months ago (2016-09-23 19:42:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369573002/1
4 years, 3 months ago (2016-09-23 19:50:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 20:20:23 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 20:24:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba47c148cdccdb687d79991f306f36eeb9ee5d2e
Cr-Commit-Position: refs/heads/master@{#420714}

Powered by Google App Engine
This is Rietveld 408576698