Suppress sandbox deprecation warnings by using the Seatbelt wrapper.

Suppress sandbox deprecation warnings by using the Seatbelt wrapper.

OS X deprecated all of the Sandbox API and never provided a replacement.
To hide the deprecation suppressions in the code, we use a wrapper
class.

BUG=chromium:622489
NOPRESUBMIT=true

Committed: https://crrev.com/df7ac746097f96e4b6150c017f1e0f7f722926ca
Cr-Commit-Position: refs/heads/master@{#420799}

[Greg K, 2016-09-23 19:06:13]

kerrnel@chromium.org changed reviewers:
+ rsesek@chromium.org

[Greg K, 2016-09-23 19:06:14]

Robert, please review, thanks.

- Greg

[Robert Sesek, 2016-09-23 19:08:47]

https://codereview.chromium.org/2369553002/diff/1/chrome/utility/safe_browsin...
File chrome/utility/safe_browsing/mac/crdmg.cc (right):

https://codereview.chromium.org/2369553002/diff/1/chrome/utility/safe_browsin...
chrome/utility/safe_browsing/mac/crdmg.cc:27: #include "sandbox/mac/seatbelt.h"
Need to also update the BUILD.gn file to depend on //sandbox/mac:seatbelt (gn
--check should complain about this).

https://codereview.chromium.org/2369553002/diff/1/sandbox/mac/seatbelt.h
File sandbox/mac/seatbelt.h (right):

https://codereview.chromium.org/2369553002/diff/1/sandbox/mac/seatbelt.h#newc...
sandbox/mac/seatbelt.h:29: static const char* ProfileNoInternet();
Do these need to be functions, or can they be static member variables?

[Greg K, 2016-09-23 20:32:05]

https://codereview.chromium.org/2369553002/diff/1/chrome/utility/safe_browsin...
File chrome/utility/safe_browsing/mac/crdmg.cc (right):

https://codereview.chromium.org/2369553002/diff/1/chrome/utility/safe_browsin...
chrome/utility/safe_browsing/mac/crdmg.cc:27: #include "sandbox/mac/seatbelt.h"
On 2016/09/23 19:08:47, Robert Sesek wrote:
> Need to also update the BUILD.gn file to depend on //sandbox/mac:seatbelt (gn
> --check should complain about this).

Done.

https://codereview.chromium.org/2369553002/diff/1/sandbox/mac/seatbelt.h
File sandbox/mac/seatbelt.h (right):

https://codereview.chromium.org/2369553002/diff/1/sandbox/mac/seatbelt.h#newc...
sandbox/mac/seatbelt.h:29: static const char* ProfileNoInternet();
On 2016/09/23 19:08:47, Robert Sesek wrote:
> Do these need to be functions, or can they be static member variables?

Done.

[Robert Sesek, 2016-09-23 20:47:55]

LGTM

https://codereview.chromium.org/2369553002/diff/20001/sandbox/mac/seatbelt.cc
File sandbox/mac/seatbelt.cc (right):

https://codereview.chromium.org/2369553002/diff/20001/sandbox/mac/seatbelt.cc...
sandbox/mac/seatbelt.cc:25: kSBXProfileNoWriteExceptTemporary;
Formatting here is a bit odd. Did clang-format do this (if so, keep it)?
Normally it'd just be +4 spaces.

[Greg K, 2016-09-23 21:14:04]

kerrnel@chromium.org changed reviewers:
+ thakis@chromium.org, tsepez@chromium.org

[Greg K, 2016-09-23 21:14:05]

tsepez@chromium.org: Please review changes in 
ipc/*

thakis@chromium.org: Please review changes in 
safe_browsing/*

Thanks,

Greg

https://codereview.chromium.org/2369553002/diff/20001/sandbox/mac/seatbelt.cc
File sandbox/mac/seatbelt.cc (right):

https://codereview.chromium.org/2369553002/diff/20001/sandbox/mac/seatbelt.cc...
sandbox/mac/seatbelt.cc:25: kSBXProfileNoWriteExceptTemporary;
On 2016/09/23 20:47:55, Robert Sesek wrote:
> Formatting here is a bit odd. Did clang-format do this (if so, keep it)?
> Normally it'd just be +4 spaces.

Done.

[Nico, 2016-09-23 21:14:49]

lgtm, thanks!

[Tom Sepez, 2016-09-23 21:44:43]

lgtm

[Greg K, 2016-09-23 21:45:58]

The CQ bit was checked by kerrnel@chromium.org

[Greg K, 2016-09-23 21:45:58]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2369553002/#ps40001
(title: "Suppress sandbox deprecation warnings by using the Seatbelt wrapper.")

[commit-bot: I haz the power, 2016-09-23 21:46:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 21:57:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:57:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Robert Sesek, 2016-09-23 21:59:52]

On 2016/09/23 21:57:03, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

You have to use NOPRESUBMIT=true to skip the message about printf.

[Greg K, 2016-09-23 22:01:26]

Description was changed from

==========
Suppress sandbox deprecation warnings by using the Seatbelt wrapper.

OS X deprecated all of the Sandbox API and never provided a replacement.
To hide the deprecation suppressions in the code, we use a wrapper
class.

BUG=chromium:622489
==========

to

==========
Suppress sandbox deprecation warnings by using the Seatbelt wrapper.

OS X deprecated all of the Sandbox API and never provided a replacement.
To hide the deprecation suppressions in the code, we use a wrapper
class.

BUG=chromium:622489
NOPRESUBMIT=true
==========

[Greg K, 2016-09-23 23:11:12]

The CQ bit was checked by kerrnel@chromium.org

[Greg K, 2016-09-23 23:11:12]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
tsepez@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2369553002/#ps60001
(title: "Suppress sandbox deprecation warnings by using the Seatbelt wrapper.")

[commit-bot: I haz the power, 2016-09-23 23:11:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 00:40:06]

Description was changed from

==========
Suppress sandbox deprecation warnings by using the Seatbelt wrapper.

OS X deprecated all of the Sandbox API and never provided a replacement.
To hide the deprecation suppressions in the code, we use a wrapper
class.

BUG=chromium:622489
NOPRESUBMIT=true
==========

to

==========
Suppress sandbox deprecation warnings by using the Seatbelt wrapper.

OS X deprecated all of the Sandbox API and never provided a replacement.
To hide the deprecation suppressions in the code, we use a wrapper
class.

BUG=chromium:622489
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-09-24 00:40:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-24 00:41:31]

Description was changed from

==========
Suppress sandbox deprecation warnings by using the Seatbelt wrapper.

OS X deprecated all of the Sandbox API and never provided a replacement.
To hide the deprecation suppressions in the code, we use a wrapper
class.

BUG=chromium:622489
NOPRESUBMIT=true
==========

to

==========
Suppress sandbox deprecation warnings by using the Seatbelt wrapper.

OS X deprecated all of the Sandbox API and never provided a replacement.
To hide the deprecation suppressions in the code, we use a wrapper
class.

BUG=chromium:622489
NOPRESUBMIT=true

Committed: https://crrev.com/df7ac746097f96e4b6150c017f1e0f7f722926ca
Cr-Commit-Position: refs/heads/master@{#420799}
==========

[commit-bot: I haz the power, 2016-09-24 00:41:33]

Patchset 4 (id:??) landed as
https://crrev.com/df7ac746097f96e4b6150c017f1e0f7f722926ca
Cr-Commit-Position: refs/heads/master@{#420799}