Don't compute path keys for volatile paths in GrShape.

Don't compute path keys for volatile paths in GrShape.

Otherwise, we will compute cache keys for internally transformed paths that don't repeat (e.g. clip paths transformed into device space with a changing view matrix).

BUG=chromium:649562
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369513002

Committed: https://skia.googlesource.com/skia/+/aa840647fc7f057715bce62489b96c4299385135

[bsalomon, 2016-09-23 15:45:39]

Description was changed from

==========
Don't compute path keys for volatile paths in GrShape.

Otherwise, we will compute cache keys for internally transformed paths that
don't repeat (e.g. clip paths transformed into device space with a changing view
matrix).

BUG=chromium:649562
==========

to

==========
Don't compute path keys for volatile paths in GrShape.

Otherwise, we will compute cache keys for internally transformed paths that
don't repeat (e.g. clip paths transformed into device space with a changing view
matrix).

BUG=chromium:649562
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369513002
==========

[bsalomon, 2016-09-23 15:47:03]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-09-23 15:47:04]

I think this may have been one of your questions on the original CL. I must have
confused myself when I thought about it. The case that the data-based keys was
trying to help involves non-volatile paths so will be unaffected by this change.

[bsalomon, 2016-09-23 15:56:29]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-09-23 15:56:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 15:56:33]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-09-23 21:56 UTC

[commit-bot: I haz the power, 2016-09-23 16:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 16:03:51]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[bsalomon, 2016-09-23 16:15:50]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 16:16:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-09-23 16:17:56]

lgtm

[commit-bot: I haz the power, 2016-09-23 16:25:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 16:25:11]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[bsalomon, 2016-09-23 18:30:19]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-09-23 18:30:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2369513002/#ps40001
(title: "fix test")

[commit-bot: I haz the power, 2016-09-23 18:30:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 19:09:18]

Description was changed from

==========
Don't compute path keys for volatile paths in GrShape.

Otherwise, we will compute cache keys for internally transformed paths that
don't repeat (e.g. clip paths transformed into device space with a changing view
matrix).

BUG=chromium:649562
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369513002
==========

to

==========
Don't compute path keys for volatile paths in GrShape.

Otherwise, we will compute cache keys for internally transformed paths that
don't repeat (e.g. clip paths transformed into device space with a changing view
matrix).

BUG=chromium:649562
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369513002

Committed:
https://skia.googlesource.com/skia/+/aa840647fc7f057715bce62489b96c4299385135
==========

[commit-bot: I haz the power, 2016-09-23 19:09:21]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/aa840647fc7f057715bce62489b96c4299385135