Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2369513002: Don't compute path keys for volatile paths in GrShape. (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't compute path keys for volatile paths in GrShape. Otherwise, we will compute cache keys for internally transformed paths that don't repeat (e.g. clip paths transformed into device space with a changing view matrix). BUG=chromium:649562 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369513002 Committed: https://skia.googlesource.com/skia/+/aa840647fc7f057715bce62489b96c4299385135

Patch Set 1 #

Patch Set 2 : change expectation for GrPath keys test #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -36 lines) Patch
M src/gpu/GrShape.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 2 2 chunks +11 lines, -7 lines 0 comments Download
M tests/GrShapeTest.cpp View 4 chunks +19 lines, -25 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
bsalomon
I think this may have been one of your questions on the original CL. I ...
4 years, 3 months ago (2016-09-23 15:47:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369513002/1
4 years, 3 months ago (2016-09-23 15:56:32 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-23 15:56:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot/builds/1442)
4 years, 3 months ago (2016-09-23 16:03:51 UTC) #8
robertphillips
lgtm
4 years, 3 months ago (2016-09-23 16:17:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2369513002/40001
4 years, 3 months ago (2016-09-23 18:30:23 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 19:09:21 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/aa840647fc7f057715bce62489b96c4299385135

Powered by Google App Engine
This is Rietveld 408576698