Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: infra/mb/mb_config.pyl

Issue 2369493002: [gn] Use clang plugins on win clang bot (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/mb/mb_config.pyl
diff --git a/infra/mb/mb_config.pyl b/infra/mb/mb_config.pyl
index 394bb55925f33bc333541ad562e57976b817192e..4e60194b9b140a65f0e1a2700411f3b7ead15220 100644
--- a/infra/mb/mb_config.pyl
+++ b/infra/mb/mb_config.pyl
@@ -53,7 +53,7 @@
'V8 Win64': 'gn_release_x64_minimal_symbols',
'V8 Win64 - debug': 'gn_debug_x64_minimal_symbols',
# TODO(machenbach): Switch plugins on when errors are fixed.
- 'V8 Win64 - clang': 'gn_release_x64_clang_no_plugins',
+ 'V8 Win64 - clang': 'gn_release_x64_clang',
# Mac.
'V8 Mac': 'gn_release_x86',
'V8 Mac - debug': 'gn_debug_x86',
@@ -282,8 +282,8 @@
'gn_release_x64_asan_symbolized_edge_verify_heap': [
'gn', 'release_bot', 'x64', 'asan', 'edge', 'lsan', 'symbolized',
'v8_verify_heap'],
- 'gn_release_x64_clang_no_plugins': [
- 'gn', 'release_bot', 'x64', 'clang', 'no_plugins', 'swarming'],
+ 'gn_release_x64_clang': [
+ 'gn', 'release_bot', 'x64', 'clang', 'swarming'],
'gn_release_x64_internal': [
'gn', 'release_bot', 'x64', 'swarming', 'v8_snapshot_internal'],
'gn_release_x64_minimal_symbols': [
@@ -516,10 +516,6 @@
'use_prebuilt_instrumented_libraries=1'),
},
- 'no_plugins': {
- 'gn_args': 'clang_use_chrome_plugins=false',
- },
-
'release': {
'gn_args': 'is_debug=false',
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698