Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2369463003: Pull linter `0.1.27` into the SDK. (Closed)

Created:
4 years, 3 months ago by pquitslund
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pull linter `0.1.27` into the SDK. * Fixed cast exception in `dart_type_utilities` (dart-lang/sdk#27405). * New `parameter_assignments` lint. * New `prefer_final_fields` lint. * New `prefer_final_locals` lint. * Markdown link fixes in docs (#306). * Miscellaneous solo test running fixes and introduction of `solo_debug` (#304). R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/bb4e0798dfd164e87b14989dba78f58364d10bc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
pquitslund
4 years, 3 months ago (2016-09-23 20:55:49 UTC) #3
scheglov
LGTM
4 years, 3 months ago (2016-09-23 20:56:16 UTC) #4
pquitslund
Committed patchset #1 (id:1) manually as bb4e0798dfd164e87b14989dba78f58364d10bc6 (presubmit successful).
4 years, 3 months ago (2016-09-23 21:00:11 UTC) #6
Brian Wilkerson
4 years, 3 months ago (2016-09-23 21:20:40 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698