Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: src/compiler/x64/code-generator-x64.cc

Issue 2369463002: Merged: [turbofan] Remove bogus constant materialization from frame. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/s390/code-generator-s390.cc ('k') | src/compiler/x87/code-generator-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 2459 matching lines...) Expand 10 before | Expand all | Expand 10 after
2470 case Constant::kFloat64: 2470 case Constant::kFloat64:
2471 __ Move(dst, 2471 __ Move(dst,
2472 isolate()->factory()->NewNumber(src.ToFloat64(), TENURED)); 2472 isolate()->factory()->NewNumber(src.ToFloat64(), TENURED));
2473 break; 2473 break;
2474 case Constant::kExternalReference: 2474 case Constant::kExternalReference:
2475 __ Move(dst, src.ToExternalReference()); 2475 __ Move(dst, src.ToExternalReference());
2476 break; 2476 break;
2477 case Constant::kHeapObject: { 2477 case Constant::kHeapObject: {
2478 Handle<HeapObject> src_object = src.ToHeapObject(); 2478 Handle<HeapObject> src_object = src.ToHeapObject();
2479 Heap::RootListIndex index; 2479 Heap::RootListIndex index;
2480 int slot; 2480 if (IsMaterializableFromRoot(src_object, &index)) {
2481 if (IsMaterializableFromFrame(src_object, &slot)) {
2482 __ movp(dst, g.SlotToOperand(slot));
2483 } else if (IsMaterializableFromRoot(src_object, &index)) {
2484 __ LoadRoot(dst, index); 2481 __ LoadRoot(dst, index);
2485 } else { 2482 } else {
2486 __ Move(dst, src_object); 2483 __ Move(dst, src_object);
2487 } 2484 }
2488 break; 2485 break;
2489 } 2486 }
2490 case Constant::kRpoNumber: 2487 case Constant::kRpoNumber:
2491 UNREACHABLE(); // TODO(dcarney): load of labels on x64. 2488 UNREACHABLE(); // TODO(dcarney): load of labels on x64.
2492 break; 2489 break;
2493 } 2490 }
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
2661 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc; 2658 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc;
2662 __ Nop(padding_size); 2659 __ Nop(padding_size);
2663 } 2660 }
2664 } 2661 }
2665 2662
2666 #undef __ 2663 #undef __
2667 2664
2668 } // namespace compiler 2665 } // namespace compiler
2669 } // namespace internal 2666 } // namespace internal
2670 } // namespace v8 2667 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/s390/code-generator-s390.cc ('k') | src/compiler/x87/code-generator-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698