Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: src/compiler/mips/code-generator-mips.cc

Issue 2369463002: Merged: [turbofan] Remove bogus constant materialization from frame. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ia32/code-generator-ia32.cc ('k') | src/compiler/mips64/code-generator-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ast/scopes.h" 5 #include "src/ast/scopes.h"
6 #include "src/compiler/code-generator.h" 6 #include "src/compiler/code-generator.h"
7 #include "src/compiler/code-generator-impl.h" 7 #include "src/compiler/code-generator-impl.h"
8 #include "src/compiler/gap-resolver.h" 8 #include "src/compiler/gap-resolver.h"
9 #include "src/compiler/node-matchers.h" 9 #include "src/compiler/node-matchers.h"
10 #include "src/compiler/osr.h" 10 #include "src/compiler/osr.h"
(...skipping 1995 matching lines...) Expand 10 before | Expand all | Expand 10 after
2006 break; 2006 break;
2007 case Constant::kFloat64: 2007 case Constant::kFloat64:
2008 __ li(dst, isolate()->factory()->NewNumber(src.ToFloat64(), TENURED)); 2008 __ li(dst, isolate()->factory()->NewNumber(src.ToFloat64(), TENURED));
2009 break; 2009 break;
2010 case Constant::kExternalReference: 2010 case Constant::kExternalReference:
2011 __ li(dst, Operand(src.ToExternalReference())); 2011 __ li(dst, Operand(src.ToExternalReference()));
2012 break; 2012 break;
2013 case Constant::kHeapObject: { 2013 case Constant::kHeapObject: {
2014 Handle<HeapObject> src_object = src.ToHeapObject(); 2014 Handle<HeapObject> src_object = src.ToHeapObject();
2015 Heap::RootListIndex index; 2015 Heap::RootListIndex index;
2016 int slot; 2016 if (IsMaterializableFromRoot(src_object, &index)) {
2017 if (IsMaterializableFromFrame(src_object, &slot)) {
2018 __ lw(dst, g.SlotToMemOperand(slot));
2019 } else if (IsMaterializableFromRoot(src_object, &index)) {
2020 __ LoadRoot(dst, index); 2017 __ LoadRoot(dst, index);
2021 } else { 2018 } else {
2022 __ li(dst, src_object); 2019 __ li(dst, src_object);
2023 } 2020 }
2024 break; 2021 break;
2025 } 2022 }
2026 case Constant::kRpoNumber: 2023 case Constant::kRpoNumber:
2027 UNREACHABLE(); // TODO(titzer): loading RPO numbers on mips. 2024 UNREACHABLE(); // TODO(titzer): loading RPO numbers on mips.
2028 break; 2025 break;
2029 } 2026 }
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
2212 padding_size -= v8::internal::Assembler::kInstrSize; 2209 padding_size -= v8::internal::Assembler::kInstrSize;
2213 } 2210 }
2214 } 2211 }
2215 } 2212 }
2216 2213
2217 #undef __ 2214 #undef __
2218 2215
2219 } // namespace compiler 2216 } // namespace compiler
2220 } // namespace internal 2217 } // namespace internal
2221 } // namespace v8 2218 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ia32/code-generator-ia32.cc ('k') | src/compiler/mips64/code-generator-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698