content/browser/renderer_host/render_widget_host_view_gtk.cc - Issue 23694031: Fix race conditions in window snapshot code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_gtk.cc

Issue 23694031: Fix race conditions in window snapshot code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressing further feedback, added stress test for snapshots Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_gtk.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_gtk.cc b/content/browser/renderer_host/render_widget_host_view_gtk.cc

index 9c05bca69e176e9abf7d9349c8192c587a3fb51b..9d28b880ed1aab9ef4270a03bb89be64bf7c670e 100644

--- a/content/browser/renderer_host/render_widget_host_view_gtk.cc

+++ b/content/browser/renderer_host/render_widget_host_view_gtk.cc

@@ -1069,7 +1069,7 @@ void RenderWidgetHostViewGtk::AcceleratedSurfaceBuffersSwapped(

ack_params.sync_point = 0;

RenderWidgetHostImpl::AcknowledgeBufferPresent(

params.route_id, gpu_host_id, ack_params);

- host_->FrameSwapped(params.latency_info);

+ RenderWidgetHostImpl::CompositorFrameDrawn(params.latency_info);

}

void RenderWidgetHostViewGtk::AcceleratedSurfacePostSubBuffer(

@@ -1079,7 +1079,7 @@ void RenderWidgetHostViewGtk::AcceleratedSurfacePostSubBuffer(

ack_params.sync_point = 0;

RenderWidgetHostImpl::AcknowledgeBufferPresent(

params.route_id, gpu_host_id, ack_params);

- host_->FrameSwapped(params.latency_info);

+ RenderWidgetHostImpl::CompositorFrameDrawn(params.latency_info);

}

void RenderWidgetHostViewGtk::AcceleratedSurfaceSuspend() {