Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 23694031: Fix race conditions in window snapshot code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated unittest again, attempted to address feedback from jamesr@ Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 1142 matching lines...) Expand 10 before | Expand all | Expand 10 after
1153 void SendUpdateFaviconURL(const std::vector<FaviconURL>& urls); 1153 void SendUpdateFaviconURL(const std::vector<FaviconURL>& urls);
1154 1154
1155 // Invoked from DidStopLoading(). Sends the current list of loaded favicons to 1155 // Invoked from DidStopLoading(). Sends the current list of loaded favicons to
1156 // the browser. 1156 // the browser.
1157 void DidStopLoadingIcons(); 1157 void DidStopLoadingIcons();
1158 1158
1159 // Coordinate conversion ----------------------------------------------------- 1159 // Coordinate conversion -----------------------------------------------------
1160 1160
1161 gfx::RectF ClientRectToPhysicalWindowRect(const gfx::RectF& rect) const; 1161 gfx::RectF ClientRectToPhysicalWindowRect(const gfx::RectF& rect) const;
1162 1162
1163 // Helper for LatencyInfo construction.
1164 int64 GetLatencyComponentId();
1165
1163 // --------------------------------------------------------------------------- 1166 // ---------------------------------------------------------------------------
1164 // ADDING NEW FUNCTIONS? Please keep private functions alphabetized and put 1167 // ADDING NEW FUNCTIONS? Please keep private functions alphabetized and put
1165 // it in the same order in the .cc file as it was in the header. 1168 // it in the same order in the .cc file as it was in the header.
1166 // --------------------------------------------------------------------------- 1169 // ---------------------------------------------------------------------------
1167 1170
1168 // Settings ------------------------------------------------------------------ 1171 // Settings ------------------------------------------------------------------
1169 1172
1170 WebPreferences webkit_preferences_; 1173 WebPreferences webkit_preferences_;
1171 RendererPreferences renderer_preferences_; 1174 RendererPreferences renderer_preferences_;
1172 1175
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
1530 // use the Observer interface to filter IPC messages and receive frame change 1533 // use the Observer interface to filter IPC messages and receive frame change
1531 // notifications. 1534 // notifications.
1532 // --------------------------------------------------------------------------- 1535 // ---------------------------------------------------------------------------
1533 1536
1534 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1537 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1535 }; 1538 };
1536 1539
1537 } // namespace content 1540 } // namespace content
1538 1541
1539 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1542 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698