content/renderer/gpu/render_widget_compositor.h - Issue 23694031: Fix race conditions in window snapshot code.

Side by Side Diff: content/renderer/gpu/render_widget_compositor.h

Issue 23694031: Fix race conditions in window snapshot code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added screenshot sync test to telemetry unittests, updated cc unittest Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_RENDERER_GPU_RENDER_WIDGET_COMPOSITOR_H_	5 #ifndef CONTENT_RENDERER_GPU_RENDER_WIDGET_COMPOSITOR_H_

6 #define CONTENT_RENDERER_GPU_RENDER_WIDGET_COMPOSITOR_H_	6 #define CONTENT_RENDERER_GPU_RENDER_WIDGET_COMPOSITOR_H_

7	7

8 #include "base/memory/weak_ptr.h"	8 #include "base/memory/weak_ptr.h"

9 #include "base/time/time.h"	9 #include "base/time/time.h"

10 #include "cc/debug/rendering_stats.h"	10 #include "cc/debug/rendering_stats.h"

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 void GetRenderingStats(cc::RenderingStats* stats);	47 void GetRenderingStats(cc::RenderingStats* stats);

48 void UpdateTopControlsState(cc::TopControlsState constraints,	48 void UpdateTopControlsState(cc::TopControlsState constraints,

49 cc::TopControlsState current,	49 cc::TopControlsState current,

50 bool animate);	50 bool animate);

51 void SetOverdrawBottomHeight(float overdraw_bottom_height);	51 void SetOverdrawBottomHeight(float overdraw_bottom_height);

52 void SetNeedsRedrawRect(gfx::Rect damage_rect);	52 void SetNeedsRedrawRect(gfx::Rect damage_rect);

53 void SetLatencyInfo(const ui::LatencyInfo& latency_info);	53 void SetLatencyInfo(const ui::LatencyInfo& latency_info);

54 int GetLayerTreeId() const;	54 int GetLayerTreeId() const;

55 void NotifyInputThrottledUntilCommit();	55 void NotifyInputThrottledUntilCommit();

56 const cc::Layer* GetRootLayer() const;	56 const cc::Layer* GetRootLayer() const;

	57 // Like setNeedsRedraw, but forces the frame to be drawn, without

	58 // any early-outs.
	jamesr 2013/10/02 00:06:41 is this the same as SetNeedsRedrawRect(...)? i.e., is this the same as SetNeedsRedrawRect(...)? i.e., force window damage? If it's not, could you explain in the comment how it's different? This function should be next to that in the header since the two are closely related
	59 void SetNeedsForcedRedraw();

57	60

58 // WebLayerTreeView implementation.	61 // WebLayerTreeView implementation.

59 virtual void setSurfaceReady();	62 virtual void setSurfaceReady();

60 virtual void setRootLayer(const WebKit::WebLayer& layer);	63 virtual void setRootLayer(const WebKit::WebLayer& layer);

61 virtual void clearRootLayer();	64 virtual void clearRootLayer();

62 virtual void setViewportSize(	65 virtual void setViewportSize(

63 const WebKit::WebSize& unused_deprecated,	66 const WebKit::WebSize& unused_deprecated,

64 const WebKit::WebSize& device_viewport_size);	67 const WebKit::WebSize& device_viewport_size);

65 virtual WebKit::WebSize layoutViewportSize() const;	68 virtual WebKit::WebSize layoutViewportSize() const;

66 virtual WebKit::WebSize deviceViewportSize() const;	69 virtual WebKit::WebSize deviceViewportSize() const;

(...skipping 59 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
126	129

127 bool threaded_;	130 bool threaded_;

128 bool suppress_schedule_composite_;	131 bool suppress_schedule_composite_;

129 RenderWidget* widget_;	132 RenderWidget* widget_;

130 scoped_ptr<cc::LayerTreeHost> layer_tree_host_;	133 scoped_ptr<cc::LayerTreeHost> layer_tree_host_;

131 };	134 };

132	135

133 } // namespace content	136 } // namespace content

134	137

135 #endif // CONTENT_RENDERER_GPU_RENDER_WIDGET_COMPOSITOR_H_	138 #endif // CONTENT_RENDERER_GPU_RENDER_WIDGET_COMPOSITOR_H_

OLD	NEW

« cc/trees/layer_tree_host_unittest.cc ('K') | « content/common/view_messages.h ('k') | content/renderer/gpu/render_widget_compositor.cc » ('j') | content/renderer/render_view_impl.cc » ('J')