Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 23694031: Fix race conditions in window snapshot code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing further feedback, added stress test for snapshots Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <list> 9 #include <list>
10 #include <map> 10 #include <map>
(...skipping 749 matching lines...) Expand 10 before | Expand all | Expand 10 after
760 760
761 void SimulateTouchGestureWithMouse(const WebKit::WebMouseEvent& mouse_event); 761 void SimulateTouchGestureWithMouse(const WebKit::WebMouseEvent& mouse_event);
762 762
763 // Called when there is a new auto resize (using a post to avoid a stack 763 // Called when there is a new auto resize (using a post to avoid a stack
764 // which may get in recursive loops). 764 // which may get in recursive loops).
765 void DelayedAutoResized(); 765 void DelayedAutoResized();
766 766
767 // Creates the proper InputRouter, either Buffered or Immediate. 767 // Creates the proper InputRouter, either Buffered or Immediate.
768 scoped_ptr<InputRouter> CreateInputRouter(); 768 scoped_ptr<InputRouter> CreateInputRouter();
769 769
770 void WindowSnapshotReachedScreen(int snapshot_id);
771
770 // Our delegate, which wants to know mainly about keyboard events. 772 // Our delegate, which wants to know mainly about keyboard events.
771 // It will remain non-NULL until DetachDelegate() is called. 773 // It will remain non-NULL until DetachDelegate() is called.
772 RenderWidgetHostDelegate* delegate_; 774 RenderWidgetHostDelegate* delegate_;
773 775
774 // Created during construction but initialized during Init*(). Therefore, it 776 // Created during construction but initialized during Init*(). Therefore, it
775 // is guaranteed never to be NULL, but its channel may be NULL if the 777 // is guaranteed never to be NULL, but its channel may be NULL if the
776 // renderer crashed, so you must always check that. 778 // renderer crashed, so you must always check that.
777 RenderProcessHost* process_; 779 RenderProcessHost* process_;
778 780
779 // The ID of the corresponding object in the Renderer Instance. 781 // The ID of the corresponding object in the Renderer Instance.
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 int64 last_input_number_; 942 int64 last_input_number_;
941 943
942 BrowserRenderingStats rendering_stats_; 944 BrowserRenderingStats rendering_stats_;
943 945
944 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl); 946 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl);
945 }; 947 };
946 948
947 } // namespace content 949 } // namespace content
948 950
949 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 951 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698