Source/core/rendering/RenderGrid.cpp - Issue 23694023: Remove an extra relayout for non-percent logical height grid items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderGrid.cpp

Issue 23694023: Remove an extra relayout for non-percent logical height grid items (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated patch: Uses RenderBox::hasRelativeLogicalHeight and includes testing for min-height/max-hei… Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderGrid.cpp

diff --git a/Source/core/rendering/RenderGrid.cpp b/Source/core/rendering/RenderGrid.cpp

index cd2d268e4cc698a6118351e88b355458386dfef6..4744fa6a09d03a0eb06c0912c190b6ff700f4960 100644

--- a/Source/core/rendering/RenderGrid.cpp

+++ b/Source/core/rendering/RenderGrid.cpp

@@ -870,7 +870,7 @@ void RenderGrid::layoutGridItems()

LayoutUnit overrideContainingBlockContentLogicalHeight = gridAreaBreadthForChild(child, ForRows, rowTracks);

SubtreeLayoutScope layoutScope(child);

- if (oldOverrideContainingBlockContentLogicalWidth != overrideContainingBlockContentLogicalWidth || oldOverrideContainingBlockContentLogicalHeight != overrideContainingBlockContentLogicalHeight)

+ if (oldOverrideContainingBlockContentLogicalWidth != overrideContainingBlockContentLogicalWidth || (child->hasRelativeLogicalHeight() && oldOverrideContainingBlockContentLogicalHeight != overrideContainingBlockContentLogicalHeight))

Julien - ping for review 2013/09/11 00:06:05 I went ahead and switched to RenderBox::hasRelativ

layoutScope.setNeedsLayout(child);

child->setOverrideContainingBlockContentLogicalWidth(overrideContainingBlockContentLogicalWidth);

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic-expected.txt ('k') | no next file » | no next file with comments »