Issue 23694014: MIPS: Support for DoubleToIStub (truncating).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23694014: MIPS: Support for DoubleToIStub (truncating). (Closed)

Created:
7 years, 3 months ago by kilvadyb

Modified:
7 years, 3 months ago

Reviewers:
Jakob Kummerow, Paul Lind, rmcilroy, kisg, palfia, rmcilroy_google, danno

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

More Reviews

Description

MIPS: Support for DoubleToIStub (truncating). Port r16322 (8a03070) Original commit message: Added support for truncating DoubleToIStub and reorganize the macro-assembler dToI operations to do the fast-path inline and the slow path by calling the stub. BUG=

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+220 lines, -154 lines)			Patch
M	src/mips/code-stubs-mips.h	View	2 chunks	+1 line, -14 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	2 chunks	+62 lines, -4 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	5 chunks	+8 lines, -35 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	3 chunks	+6 lines, -17 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	2 chunks	+33 lines, -16 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	4 chunks	+105 lines, -58 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rmcilroy_google

7 years, 3 months ago (2013-09-02 13:26:31 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/23694014/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):

https://codereview.chromium.org/23694014/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.cc:1588: &not_in_int32_range);
Any particular reason you are not doing using TruncateHeapNumberToI here? This
would simplify the code, and mean you could maybe get rid of a couple of other
macro assembler instructions (e.g., ConvertToInt32 and
EmitOutOfInt32RangeTruncate).

Expand Messages | Collapse Messages