Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 23694011: Make implicit HandleScope of AssertNoContextChange explicit. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Make implicit HandleScope of AssertNoContextChange explicit. R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16437

Patch Set 1 #

Patch Set 2 : One spot missed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -14 lines) Patch
M src/isolate.h View 2 chunks +21 lines, -3 lines 0 comments Download
M src/objects.cc View 1 11 chunks +21 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 3 months ago (2013-08-29 16:02:47 UTC) #1
Toon Verwaest
lgtm
7 years, 3 months ago (2013-08-29 17:04:39 UTC) #2
Michael Starzinger
7 years, 3 months ago (2013-08-29 17:14:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16437 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698