LogDnsClient now returns some errors synchronously

components/certificate_transparency/log_dns_client.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CERTIFICATE_TRANSPARENCY_LOG_DNS_CLIENT_H_
 #define COMPONENTS_CERTIFICATE_TRANSPARENCY_LOG_DNS_CLIENT_H_
 
 #include <stdint.h>
 
 #include <list>
-#include <string>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/strings/string_piece.h"
 #include "net/base/network_change_notifier.h"
 #include "net/log/net_log.h"
 
 namespace net {
 class DnsClient;
-class DnsResponse;
-class DnsTransaction;
 namespace ct {
 struct MerkleAuditProof;
 }  // namespace ct
 }  // namespace net
 
 namespace certificate_transparency {
 
 // Queries Certificate Transparency (CT) log servers via DNS.
 // All queries are performed asynchronously.
 // For more information, see
@@ skipping 30 matching lines @@
 
   // Called by NetworkChangeNotifier when the DNS config is first read.
   // The DnsClient's config will be updated in response.
   void OnInitialDNSConfigRead() override;
 
   // Queries a CT log to retrieve an audit proof for the leaf with |leaf_hash|.
   // The |leaf_hash| is the SHA-256 Merkle leaf hash (see RFC6962, section 2.1).
   // The size of the CT log tree must be provided in |tree_size|.
   // The log is identified by |domain_for_log|, which is the DNS name used as a
   // suffix for all queries.
   // The |callback| is invoked when the query is complete, or an error occurs.

[Eran Messeri, 2016/09/28 13:44:08]

Document the return value - that on successful submission ERR_IO_PENDING  will
be returned, another error code to indicate throttling (and everything else is a
hard-fail).

[Rob Percival, 2016/09/28 16:19:14]

Done.

-  void QueryAuditProof(const std::string& domain_for_log,
-                       base::StringPiece leaf_hash,
-                       uint64_t tree_size,
-                       const AuditProofCallback& callback);
+  int QueryAuditProof(base::StringPiece domain_for_log,

[Eran Messeri, 2016/09/28 13:44:08]

Question to rsleevi: Why not use net::Error here?

+                      base::StringPiece leaf_hash,
+                      uint64_t tree_size,
+                      const AuditProofCallback& callback);
 
  private:
   // An audit proof query that is in progress.
   class AuditProofQuery;
 
   // Invoked when an audit proof query completes.
   // |callback| is the user-provided callback that should be notified.
   // |result| is a net::Error indicating success or failure.
   // |query| is the query that has completed.
   // The query is removed from |audit_proof_queries_| by this method.
   void QueryAuditProofComplete(const AuditProofCallback& callback,
                                int result,
                                AuditProofQuery* query);
 
   // Returns true if the maximum number of queries are currently in flight.
   // If the maximum number of concurrency queries is set to 0, this will always
   // return false.
   bool HasMaxConcurrentQueriesInProgress() const;
 
   // Updates the |dns_client_| config using NetworkChangeNotifier.
   void UpdateDnsConfig();
 
   // Used to perform DNS queries.
   std::unique_ptr<net::DnsClient> dns_client_;
   // Passed to the DNS client for logging.
   net::BoundNetLog net_log_;
   // Audit proof queries that haven't completed yet.
+  // Expected to typically be a FIFO queue of queries, so a std::list should be
+  // efficient.

[Eran Messeri, 2016/09/28 13:44:08]

Be more explicit in the comment:
// A FIFO queue of queries. Since entries will always be appended to the
// end of the queue and lookups will yield entries at the beginning,
// std::list is the efficient choice.

[Rob Percival, 2016/09/28 16:19:14]

Done.

   std::list<std::unique_ptr<AuditProofQuery>> audit_proof_queries_;
   // The maximum number of queries that can be in flight at one time.
   size_t max_concurrent_queries_;
   // Creates weak_ptrs to this, for callback purposes.
   base::WeakPtrFactory<LogDnsClient> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(LogDnsClient);
 };
 
 }  // namespace certificate_transparency
 #endif  // COMPONENTS_CERTIFICATE_TRANSPARENCY_LOG_DNS_CLIENT_H_