Adds a pref and a policy to decide if PDFs should always be opened externally.

chrome/browser/plugins/plugin_prefs.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PLUGINS_PLUGIN_PREFS_H_
 #define CHROME_BROWSER_PLUGINS_PLUGIN_PREFS_H_
 
 #include <map>
 #include <set>
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "base/synchronization/lock.h"
 #include "chrome/browser/plugins/plugin_finder.h"
+#include "chrome/common/chrome_content_client.h"
 #include "components/keyed_service/core/refcounted_keyed_service.h"
 #include "components/prefs/pref_change_registrar.h"
 #include "components/prefs/pref_service.h"
 
 class Profile;
 
 namespace base {
 class ListValue;
 }
 
@@ skipping 74 matching lines @@
     std::map<base::FilePath, bool> state_;
   };
 
   ~PluginPrefs() override;
 
   // Called to update one of the policy_xyz patterns below when a
   // preference changes.
   void UpdatePatternsAndNotify(std::set<base::string16>* patterns,
                                const std::string& pref_name);
 
+  // Callback for changes to the AlwaysOpenPdfExternally policy.
+  void UpdatePdfPolicy(const std::string& pref_name);
+
   // Allows unit tests to directly set enforced plugin patterns.
   void SetPolicyEnforcedPluginPatterns(
       const std::set<base::string16>& disabled_patterns,
       const std::set<base::string16>& disabled_exception_patterns,
       const std::set<base::string16>& enabled_patterns);
 
+  // Allows unit tests to directly set the AlwaysOpenPdfExternally pref.
+  void SetAlwaysOpenPdfExternally(bool always_open_pdf_externally);

[Bernhard Bauer, 2016/09/29 08:44:35]

If this is for tests, add ...ForTesting.

[pastarmovj, 2016/09/29 12:14:41]

I kept it consistent with SetPolicyEnforcedPluginPatterns but since both are
only used in tests now I think this is fair change.

+
   // Callback for after the plugin groups have been loaded.
   void EnablePluginGroupInternal(
       bool enabled,
       const base::string16& group_name,
       const std::vector<content::WebPluginInfo>& plugins);
   void EnablePluginInternal(
       bool enabled,
       const base::FilePath& path,
       PluginFinder* plugin_finder,
       const base::Callback<void(bool)>& callback,
@@ skipping 14 matching lines @@
 
   // Guards access to the following data structures.
   mutable base::Lock lock_;
 
   PluginState plugin_state_;
   std::map<base::string16, bool> plugin_group_state_;
 
   std::set<base::string16> policy_disabled_plugin_patterns_;
   std::set<base::string16> policy_disabled_plugin_exception_patterns_;
   std::set<base::string16> policy_enabled_plugin_patterns_;
+  bool always_open_pdf_externally_;
 
   // Weak pointer, owns us. Only used as a notification source.
   Profile* profile_;
 
   // Weak pointer, owned by the profile.
   PrefService* prefs_;
 
   PrefChangeRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginPrefs);
 };
 
 #endif  // CHROME_BROWSER_PLUGINS_PLUGIN_PREFS_H_