Adds a pref and a policy to decide if PDFs should always be opened externally.

chrome/browser/download/download_prefs.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_PREFS_H_
 #define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_PREFS_H_
 
 #include <set>
 
 #include "base/files/file_path.h"
+#include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "components/prefs/pref_member.h"
 
 class PrefService;
 class Profile;
 
 namespace content {
 class BrowserContext;
 class DownloadManager;
@@ skipping 66 matching lines @@
   // Return whether the user prefers to open PDF downloads in the platform's
   // default reader.
   bool ShouldOpenPdfInSystemReader() const;
 #endif
 
   void ResetAutoOpen();
 
  private:
   void SaveAutoOpenState();
 
+#if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_MACOSX)
+  // Used by tests to switch off version checks for Adobe.

[Bernhard Bauer, 2016/09/29 08:44:35]

Rename the method so it states that the checks are disabled?

[pastarmovj, 2016/09/29 12:14:41]

Done.

+  void OverrideAdobeVersionCheckForTests();
+#endif
+
   Profile* profile_;
 
   BooleanPrefMember prompt_for_download_;
   FilePathPrefMember download_path_;
   FilePathPrefMember save_file_path_;
   IntegerPrefMember save_file_type_;
 
   // Set of file extensions to open at download completion.
   struct AutoOpenCompareFunctor {
     bool operator()(const base::FilePath::StringType& a,
                     const base::FilePath::StringType& b) const;
   };
   typedef std::set<base::FilePath::StringType,
                    AutoOpenCompareFunctor> AutoOpenSet;
   AutoOpenSet auto_open_;
 
 #if defined(OS_WIN) || defined(OS_LINUX) || defined(OS_MACOSX)
   bool should_open_pdf_in_system_reader_;
+  bool override_adobe_version_check_for_tests_;
+
+  FRIEND_TEST_ALL_PREFIXES(DownloadPrefsTest, AlwaysOpenPdfExternally);

[Bernhard Bauer, 2016/09/29 08:44:35]

Friend declarations go first in the private section. Alternatively, just make
the method public? It has a ...ForTests suffix anyway, which I think should be
good enough to deter people from using it in production code.

[pastarmovj, 2016/09/29 12:14:41]

Done.

 #endif
 
   DISALLOW_COPY_AND_ASSIGN(DownloadPrefs);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_PREFS_H_