appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py - Issue 2369333002: [Findit] Capture versionized metadata for master_flake_analysis

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py

Issue 2369333002: [Findit] Capture versionized metadata for master_flake_analysis (Closed)

Patch Set: Fixing nits Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/flake/recursive_flake_pipeline.py ('k') | appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py

diff --git a/appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py b/appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py

index 5afe7ed0300ec533e34ce27e25808963bd8be403..3b8c8f669463108785e1349a6d4a889d5aa00d82 100644

--- a/appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py

+++ b/appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py

@@ -22,7 +22,7 @@ class InitializeFlakePipelineTest(wf_testcase.WaterfallTestCase):

analysis = MasterFlakeAnalysis.Create(

master_name, builder_name, build_number, step_name, test_name)

analysis.status = status

- analysis.put()

+ analysis.Save()

def testAnalysisIsNotNeededWhenNoneExistsAndNotAllowedToSchedule(self):

master_name = 'm'

@@ -118,8 +118,8 @@ class InitializeFlakePipelineTest(wf_testcase.WaterfallTestCase):

step_name, test_name, allow_new_analysis=True,

queue_name=constants.DEFAULT_QUEUE)

- analysis = MasterFlakeAnalysis.Get(master_name, builder_name,

- build_number, step_name, test_name)

+ analysis = MasterFlakeAnalysis.GetVersion(

+ master_name, builder_name, build_number, step_name, test_name)

self.assertIsNotNone(analysis)

mocked_pipeline.assert_has_calls(

[mock.call().start(queue_name=constants.DEFAULT_QUEUE)])