[Findit] Capture versionized metadata for master_flake_analysis

appengine/findit/handlers/flake/check_flake.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from google.appengine.api import users
 
 from common import constants
 from common.base_handler import BaseHandler
 from common.base_handler import Permission
 from model.analysis_status import STATUS_TO_DESCRIPTION
@@ skipping 26 matching lines @@
           'data': {
               'error_message':
                   ('You could schedule an analysis for flaky test only after '
                    'you login with google.com account.'),
               'login_url': self.GetLoginUrl(),
           },
           'return_code': 401,
       }
 
     data = {
-        'success_rates': [],
+        'pass_rates': [],
         'analysis_status': STATUS_TO_DESCRIPTION.get(
             master_flake_analysis.status),
         'suspected_flake_build_number': (
             master_flake_analysis.suspected_flake_build_number),
         'master_name': master_name,
         'builder_name': builder_name,
         'build_number': build_number,
         'step_name': step_name,
         'test_name': test_name,
     }
-    zipped = zip(master_flake_analysis.build_numbers,
-                 master_flake_analysis.success_rates)
-    zipped.sort(key = lambda x: x[0])
-    for (build_number, success_rate) in zipped:
-      data['success_rates'].append([build_number, success_rate])
+
+    build_numbers = []
+    pass_rates = []
+
+    for data_point in master_flake_analysis.data_points:
+      build_numbers.append(data_point.build_number)
+      pass_rates.append(data_point.pass_rate)
+
+    zipped = zip(build_numbers, pass_rates)

[stgao, 2016/10/01 01:36:59]

Build the list directly in the for loop above.

[lijeffrey, 2016/10/01 02:51:45]

Done.

+    zipped.sort(key=lambda x: x[0])
+
+    for (build_number, pass_rate) in zipped:
+      data['pass_rates'].append([build_number, pass_rate])
     return {
         'template': 'flake/result.html',
         'data': data
     }