Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: ios/chrome/browser/BUILD.gn

Issue 2369303002: Reading List create protobuf store (Closed)
Patch Set: feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/BUILD.gn
diff --git a/ios/chrome/browser/BUILD.gn b/ios/chrome/browser/BUILD.gn
index 7583630ec9c8acd463cb370f177c912cd6917533..8035028a0c18edfc713734cf883b539b12afa68d 100644
--- a/ios/chrome/browser/BUILD.gn
+++ b/ios/chrome/browser/BUILD.gn
@@ -349,27 +349,6 @@ source_set("browser") {
"prefs/pref_observer_bridge.h",
"prefs/pref_observer_bridge.mm",
"procedural_block_types.h",
- "reading_list/reading_list_download_service.cc",
- "reading_list/reading_list_download_service.h",
- "reading_list/reading_list_download_service_factory.cc",
- "reading_list/reading_list_download_service_factory.h",
- "reading_list/reading_list_entry.cc",
- "reading_list/reading_list_entry.h",
- "reading_list/reading_list_model.cc",
- "reading_list/reading_list_model.h",
- "reading_list/reading_list_model_bridge_observer.h",
- "reading_list/reading_list_model_bridge_observer.mm",
- "reading_list/reading_list_model_factory.cc",
- "reading_list/reading_list_model_factory.h",
- "reading_list/reading_list_model_impl.cc",
- "reading_list/reading_list_model_impl.h",
- "reading_list/reading_list_model_observer.h",
- "reading_list/reading_list_model_observer.h",
- "reading_list/reading_list_model_storage.h",
- "reading_list/reading_list_model_storage_defaults.h",
- "reading_list/reading_list_model_storage_defaults.mm",
- "reading_list/url_downloader.cc",
- "reading_list/url_downloader.h",
"root_coordinator.h",
"root_coordinator.mm",
"search_engines/search_engines_util.cc",
@@ -711,6 +690,7 @@ source_set("browser") {
"//components/web_resource",
"//components/webdata_services",
"//google_apis",
+ "//ios/chrome/browser/reading_list",
"//ios/chrome/browser/variations:ios_chrome_ui_string_overrider_factory",
"//ios/chrome/common",
"//ios/chrome/common/app_group",
@@ -741,7 +721,10 @@ source_set("browser") {
"//ios/chrome/app/theme",
]
- allow_circular_includes_from = [ ":about_flags" ]
+ allow_circular_includes_from = [
+ ":about_flags",
+ "//ios/chrome/browser/reading_list",
+ ]
libs = [
"Accelerate.framework",

Powered by Google App Engine
This is Rietveld 408576698